-
Notifications
You must be signed in to change notification settings - Fork 209
feat(tokens): support latest style-dictionary build #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| * text=auto eol=lf | ||
| README.md merge=ours | ||
|
|
||
| # Treat yarn assets as binaries for diffing | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,10 +150,15 @@ jobs: | |
| echo "Changes detected" | ||
| git status | ||
| git add . | ||
| git diff > changes.diff | ||
| exit 1 | ||
| fi | ||
|
|
||
| # If there are changes, capture the changes and upload them as an artifact | ||
| - name: Capture changes | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doing this as a separate task helps us identify issues more easily in CI
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a way to validate this? I see the moved command now has a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah for sure, the --staged flags ensures we're only diffing the changes detected, meaning those we staged in the previous step. By separating it into its own step instead of including it above, the logs are now easier to read. The more command line steps you run together, the harder it is to distinguish the results in the log output. |
||
| if: ${{ failure() }} | ||
| id: capture-changes | ||
| run: git diff --staged > changes.diff | ||
|
|
||
| - name: Upload changes | ||
| if: ${{ failure() }} | ||
| uses: actions/upload-artifact@v4 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.