refactor(button): remove spectrum-ButtonWithFocusRing extend#2725
Merged
pfulton merged 1 commit intoMay 30, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 3f67a84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
File metricsSummaryTotal size: 4.24 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsbutton
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
Contributor
|
🚀 Deployed on https://pr-2725--spectrum-css.netlify.app |
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
jawinn
force-pushed
the
jawinn/refactor-button-remove-basebutton-focus
branch
from
388b57b to
3f67a84
Compare
pfulton
approved these changes
May 30, 2024
Merged
castastrophe
pushed a commit
that referenced
this pull request
Dec 27, 2024
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Dec 29, 2024
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Dec 29, 2024
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
aramos-adobe
pushed a commit
that referenced
this pull request
Jan 9, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Jan 17, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Jan 17, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Jan 21, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Jan 22, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 5, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 7, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 7, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 7, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 11, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 24, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 24, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
castastrophe
pushed a commit
that referenced
this pull request
Feb 25, 2025
The styles had previously diverged from what this placeholder class was providing, which was causing an issue with needing to override styles with unnecessary CSS. This cleans that up by integrating the small number of styles from spectrum-ButtonWithFocusRing that were not already present, and removing that "extend".
12 tasks
This was referenced May 16, 2025
3 tasks
11 tasks
This was referenced Aug 27, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refactor: remove spectrum-ButtonWithFocusRing placeholder class
extendfrom the button componentRemoves the need for the
extendfrom this placeholder class in the button component, as the styles it provides have diverged slightly from what is in button and it was causing some unnecessary CSS to override. This should not result in any changed visuals or behavior, as the same CSS has been integrated.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
To-do list