feat!: 🎉 Spectrum 2 foundations#2786
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request brings in the Spectrum 2 design foundations tokens to start the migration from our current design system to the latest. To accommodate these changes, this pull request makes a few updates to our build to facilitate more robust theme switching.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Remaining TODOs
Validation steps
Validating the compiled output
.spectrum--expressin thedist/themes/expressfile; this class should contain --system prefixed variables.spectrum--legacyin thedist/themes/legacy.cssfile; this class should contain --system prefixed variables.spectrumin thedist/themes/spectrum.cssfile; this class should contain --system prefixed variablesdist/index-theme.cssfile but no top-level classes (i.e., no.spectrumor.spectrum--legacy)Validating the compiled token output
tokens/componentsandtokens/dist/css/componentsfolder withbridge,express,legacy, andspectrumfolders insidetokens/components/bridge/actionbutton.cssfile to match thecomponents/actionbutton/dist/index-theme.cssoutputtokens/components/spectrum/actionbutton.cssfile to match thecomponents/actionbutton/dist/themes/spectrum.cssoutputtokens/components/legacy/actionbutton.cssfile to match thecomponents/actionbutton/dist/themes/legacy.cssoutputtokens/components/express/actionbutton.cssfile to match thecomponents/actionbutton/dist/themes/express.cssoutputRegression testing
Validate:
Screenshots
To-do list