Skip to content

fix(picker): adjust line-height to prevent text cutoff #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rise-erpelding wants to merge 3 commits into from
Closed

fix(picker): adjust line-height to prevent text cutoff #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a99502
fix(picker): spelling fix
rise-erpelding Jul 17, 2024
0999366
fix(picker): temporarily set text to Thai
rise-erpelding Jul 17, 2024
71bebcb
fix(picker): set line height to eliminate text cutoff
rise-erpelding Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions components/picker/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
--spectrum-picker-font-size: var(--spectrum-font-size-100);
--spectrum-picker-font-weight: var(--spectrum-regular-font-weight);
--spectrum-picker-placeholder-font-style: var(--spectrum-default-font-style);
--spectrum-picker-line-height: var(--spectrum-line-height-100);

/* set picker line-height to the height of the picker - prevents the cutting off of diacritics in some languages */
--spectrum-picker-line-height: var(--spectrum-picker-block-size);

/* height */
--spectrum-picker-block-size: var(--spectrum-component-height-100);
Expand Down Expand Up @@ -352,7 +354,9 @@
overflow: hidden;

font-size: var(--mod-picker-font-size, var(--spectrum-picker-font-size));
line-height: var(--mod-picker-line-height, var(--spectrum-picker-line-height));

/* no mod defined to allow for maximum compatibility */
line-height: var(--spectrum-picker-line-height);
font-weight: var(--mod-picker-font-weight, var(--spectrum-picker-font-weight));

text-overflow: ellipsis;
Expand Down
1 change: 0 additions & 1 deletion components/picker/metadata/mods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
| `--mod-picker-icon-color-hover-open` |
| `--mod-picker-icon-color-key-focus` |
| `--mod-picker-inline-size` |
| `--mod-picker-line-height` |
| `--mod-picker-placeholder-font-style` |
| `--mod-picker-placeholder-font-weight` |
| `--mod-picker-spacing-bottom-to-text` |
Expand Down
8 changes: 4 additions & 4 deletions components/picker/stories/picker.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ export default {
args: {
rootClass: "spectrum-Picker",
size: "m",
label: "Country",
placeholder: "Select a country",
label: "ทั้งหมด",
placeholder: "ทั้งหมด",
isQuiet: false,
isKeyboardFocused: false,
isLoading: false,
Expand Down Expand Up @@ -207,7 +207,7 @@ const Variants = (args) => html`
...args,
isOpen: false,
withSwitch: true,
placeholder: "Select your contry of origin",
placeholder: "Select your country of origin",
isQuiet: true,
})}
</div>
Expand All @@ -220,7 +220,7 @@ const Variants = (args) => html`
isQuiet: true,
fieldLabelStyle: {"max-width": "90px"},
label: "Enter country, text should wrap",
placeholder: "Select your contry of origin"
placeholder: "Select your country of origin"
})}
</div>
</div>
Expand Down