fix: static white meter story and corrected fill colors#2965
Merged
castastrophe merged 4 commits intoAug 13, 2024
Conversation
🦋 Changeset detectedLatest commit: e41ba19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🚀 Deployed on https://pr-2965--spectrum-css.netlify.app |
Contributor
File metricsSummaryTotal size: 4.63 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsprogressbar
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
87fc3e3 to
d4136b2
Compare
d4136b2 to
c763024
Compare
c763024 to
87fde44
Compare
jawinn
reviewed
Aug 6, 2024
87fde44 to
f0e5cb8
Compare
jawinn
suggested changes
Aug 8, 2024
c9036fe to
05e5bf0
Compare
jawinn
approved these changes
Aug 9, 2024
|
|
||
| /* Static White */ | ||
| .spectrum-ProgressBar--staticWhite { | ||
| .spectrum-ProgressBar.spectrum-ProgressBar--staticWhite { |
Contributor
There was a problem hiding this comment.
I don't love that we have to increase specificity to make this work but we can address those concerns in a separate PR because it's an issue we have across the project.
castastrophe
approved these changes
Aug 12, 2024
3557f37 to
6375a73
Compare
6375a73 to
e41ba19
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because meter just extends the
ProgressBar.args,staticWhiteshows in the meter controls in Storybook. During the work in #2929, we noticed that the positive, negative and notice fill colors for meter do not respond as expected when looking at astaticWhitestory. WhenstaticWhitewas turned on, the positive, negative and notice colors remained the same, while the default story (and all of the progress bar stories) have reinforced, white fill colors.🚫

After checking with design (Nadeen), it was confirmed all stories should have the same fill colors as the default story when
staticWhiteis toggled on:✅

This PR adds the static white story to meter to increase Chromatic coverage, and adds CSS to enforce the static white design specs.
CSS-872
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Meter
--spectrum-progressbar-fill-color-white), and track colors turning to transparent white (--spectrum-progressbar-track-color-white)spectrum-ProgressBar(the parent element)is-positive; negative=is-negative; notice=is-notice), and also has the additionalspectrum-ProgressBar--staticWhiteclass)Regression testing
Validate:
Screenshots
To-do list