Skip to content

fix(actionbutton): prevent diacritic clipping in thai #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
castastrophe merged 2 commits into from
Oct 23, 2024
Merged

fix(actionbutton): prevent diacritic clipping in thai #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5789d49
fix(actionbutton): prevent diacritic clipping
marissahuysentruyt Oct 14, 2024
68da4c2
fix(actiongroup): revert flex: 1 setting for vertical-justified
marissahuysentruyt Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/calm-ears-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/actiongroup": patch
---

Action group

`flex: 1` has now changed to `flex-grow: 1` in the `.spectrum-ActionGroup--justified .spectrum-ActionGroup-item` selector to specify the desired behavior of justified action groups.
5 changes: 5 additions & 0 deletions .changeset/fair-badgers-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/actionbutton": patch
---

Adds line-height on `.spectrum-ActionButton-label` in order to accommodate text with diacritics that may be cut off vertically.
1 change: 1 addition & 0 deletions components/actionbutton/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ a.spectrum-ActionButton {
.spectrum-ActionButton-label {
@extend %spectrum-ButtonLabel;
pointer-events: none;
line-height: var(--spectrum-actionbutton-height);

font-size: var(--mod-actionbutton-font-size, var(--spectrum-actionbutton-font-size));
white-space: nowrap;
Expand Down
4 changes: 4 additions & 0 deletions components/actionbutton/stories/actionbutton.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ export const ActionButtonGroup = Variants({
testHeading: "Static white",
staticColor: "white",
},
{
testHeading: "Internationalization (Thai)",
label: "ล้างทั้งหมด",
},
],
stateData: [{
testHeading: "Disabled",
Expand Down
2 changes: 1 addition & 1 deletion components/actiongroup/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,5 +154,5 @@
}

.spectrum-ActionGroup--justified .spectrum-ActionGroup-item {
flex: 1;
flex-grow: 1;
}