fix(textfield,menu,tag,toast,tabs,well,popover): define custom props

[rise-erpelding]

Description

Defines undefined custom props

CSS-1083

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

@jawinn :

1. Confirm that there are no unused custom properties or unexpected duplicates for the following components (I ran nx run component-name:lint to do this):
   • Textfield
   • Menu
   • Tag
   • Toast
   • Tabs
   • Well
   • Popover
2. Confirm that visually the following components have an improved appearance. They might not match the S2 spec, but these should all be components that have not yet been migrated, or are in progress of being migrated, those migration PRs should confirm that the custom properties being used match the S2 spec.
   • Textfield
   • Menu
   • Tag
   • Toast
   • Tabs
   • Well
   • Popover

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

4. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• I have tested these changes in Windows High Contrast mode.
• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

🦋 Changeset detected

Latest commit: 588ddb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@spectrum-css/textfield	Patch
@spectrum-css/popover	Patch
@spectrum-css/toast	Patch
@spectrum-css/menu	Patch
@spectrum-css/tabs	Patch
@spectrum-css/well	Patch
@spectrum-css/tag	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🚀 Deployed on https://pr-3471--spectrum-css.netlify.app

[github-actions]

File metrics

Summary

Total size: 1.73 MB^*
Total change (Δ): 🔴 ⬆ 3.64 KB (0.21%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
menu	41.89 KB	🔴 ⬆ 0.39 KB
popover	15.65 KB	🔴 ⬆ 0.07 KB
tabs	17.11 KB	🔴 ⬆ 0.07 KB
tag	28.96 KB	🔴 ⬆ 2.47 KB
textfield	32.31 KB	🔴 ⬆ 0.42 KB
toast	7.90 KB	🔴 ⬆ 0.17 KB
well	1.58 KB	🔴 ⬆ 0.07 KB

Details

menu

Filename	Head	Compared to base
index.css	41.89 KB	🔴 ⬆ 0.39 KB (0.93%)

popover

Filename	Head	Compared to base
index.css	15.65 KB	🔴 ⬆ 0.07 KB (0.43%)

tabs

Filename	Head	Compared to base
index.css	17.11 KB	🔴 ⬆ 0.07 KB (0.38%)

tag

Filename	Head	Compared to base
index.css	28.96 KB	🔴 ⬆ 2.47 KB (9.32%)

textfield

Filename	Head	Compared to base
index.css	32.31 KB	🔴 ⬆ 0.42 KB (1.29%)

toast

Filename	Head	Compared to base
index.css	7.90 KB	🔴 ⬆ 0.17 KB (2.20%)

well

Filename	Head	Compared to base
index.css	1.58 KB	🔴 ⬆ 0.07 KB (4.80%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[jawinn]

Looks good! I see improvements from all of these fixes.

Note: It looks like the darker grey background color oddity in menu is token related and would be one of those things handled when migrating it. So that doesn't appear related to the missing variables.