fix: restore undefined custom properties [part 4] by jawinn · Pull Request #3473 · adobe/spectrum-css

jawinn · 2025-01-03T16:09:47Z

Description

Restore missing custom properties from the foundations spectrum two theme files that were flagged by the linter. This fixes linter errors for the following components: search, combobox, colorwheel, assetcard, and treeview.

CSS-1086

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Checked by @5t3ph

yarn linter search no longer shows errors or warnings
yarn linter combobox no longer shows errors or warnings
yarn linter colorwheel no longer shows errors or warnings
yarn linter assetcard no longer shows errors or warnings
yarn linter treeview no longer shows errors or warnings

To-do list

I have read the contribution guidelines.
✨ This pull request is ready to merge. ✨

changeset-bot · 2025-01-03T16:09:52Z

🦋 Changeset detected

Latest commit: d8f691d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@spectrum-css/colorwheel	Patch
@spectrum-css/assetcard	Patch
@spectrum-css/combobox	Patch
@spectrum-css/treeview	Patch
@spectrum-css/search	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-03T16:11:33Z

🚀 Deployed on https://pr-3473--spectrum-css.netlify.app

github-actions · 2025-01-03T16:14:06Z

File metrics

Summary

Total size: 1.73 MB^*
Total change (Δ): 🔴 ⬆ 1.84 KB (0.10%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
assetcard	16.14 KB	🔴 ⬆ 0.50 KB
colorwheel	4.39 KB	🔴 ⬆ 0.08 KB
combobox	28.64 KB	🔴 ⬆ 0.42 KB
search	11.37 KB	🔴 ⬆ 0.73 KB
treeview	17.71 KB	🔴 ⬆ 0.15 KB

Details

assetcard

Filename	Head	Compared to base
index.css	16.14 KB	🔴 ⬆ 0.50 KB (3.13%)

colorwheel

Filename	Head	Compared to base
index.css	4.39 KB	🔴 ⬆ 0.08 KB (1.72%)

combobox

Filename	Head	Compared to base
index.css	28.64 KB	🔴 ⬆ 0.42 KB (1.46%)

search

Filename	Head	Compared to base
index.css	11.37 KB	🔴 ⬆ 0.73 KB (6.69%)

treeview

Filename	Head	Compared to base
index.css	17.71 KB	🔴 ⬆ 0.15 KB (0.85%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

5t3ph

All clear!

marissahuysentruyt

Things are looking good, except for combobox I believe. I don't get any errors, but I did get a few warnings about undefined --highcontrast-* variables:

Looks like they're actually related to the textfield that combobox uses. It looks like they're defined in main: https://github.com/adobe/spectrum-css/blob/main/components/textfield/index.css#L668 and in s2-foundations-redux: https://github.com/adobe/spectrum-css/blame/s2-foundations-redux/components/textfield/index.css#L648

If they're textfield custom properties, that might be taken care of in another PR, so maybe this comment can be disregarded!

marissahuysentruyt

After some troubleshooting, this is looking great! Thanks for your help and the reminder for yarn clean 👍

Restore missing properties from foundations, most of which were flagged by the linter.

Restore missing properties from foundations that were flagged by the linter.

Restore missing properties from foundations that were flagged by the linter. Also removes a group of duplicate custom property definitions that were flagged.

* fix(search): restore missing custom properties * fix(colorwheel): restore missing custom properties * fix(assetcard): restore missing custom properties * fix(treeview): restore missing custom properties Restore missing properties from foundations that were flagged by the linter. * fix(combobox): restore missing custom properties Restore missing properties from foundations that were flagged by the linter. Also removes a group of duplicate custom property definitions that were flagged.

jawinn force-pushed the jawinn/css-1086-s2-undefined-4 branch from 1768d2b to 573ed15 Compare January 3, 2025 16:17

jawinn added ready-for-review S2 Spectrum 2 labels Jan 3, 2025

jawinn force-pushed the jawinn/css-1086-s2-undefined-4 branch from 573ed15 to b72d9bc Compare January 3, 2025 16:27

5t3ph self-requested a review January 3, 2025 19:08

5t3ph approved these changes Jan 3, 2025

View reviewed changes

marissahuysentruyt reviewed Jan 3, 2025

View reviewed changes

marissahuysentruyt approved these changes Jan 3, 2025

View reviewed changes

jawinn added 6 commits January 6, 2025 11:34

fix(search): restore missing custom properties

10cafaa

Restore missing properties from foundations, most of which were flagged by the linter.

fix(colorwheel): restore missing custom properties

d51dfc1

Restore missing properties from foundations that were flagged by the linter.

fix(assetcard): restore missing custom properties

da51817

Restore missing properties from foundations that were flagged by the linter.

fix(treeview): restore missing custom properties

c8cded2

Restore missing properties from foundations that were flagged by the linter.

fix(combobox): restore missing custom properties

733175e

Restore missing properties from foundations that were flagged by the linter. Also removes a group of duplicate custom property definitions that were flagged.

chore: add changeset for linter fixes

d8f691d

jawinn force-pushed the jawinn/css-1086-s2-undefined-4 branch from 27e0774 to d8f691d Compare January 6, 2025 16:34

jawinn merged commit ab2028a into spectrum-two Jan 6, 2025

jawinn deleted the jawinn/css-1086-s2-undefined-4 branch January 6, 2025 16:45

castastrophe mentioned this pull request Apr 15, 2025

feat(tokens,card): update to @adobe/spectrum-tokens@13.3.0 #3669

Merged

12 tasks

This was referenced May 16, 2025

chore(swatch,menu,swatchgroup): fix reverted metadata assets #3752

Merged

chore: merge latest updates from main #3777

Merged

castastrophe mentioned this pull request Jul 25, 2025

ci: chromatic runs for S2 [CSS-1233] #4070

Merged

3 tasks

castastrophe mentioned this pull request Aug 6, 2025

fix: minor linting updates #4113

Merged

11 tasks

This was referenced Aug 27, 2025

chore(popover): wrapper placement in story #4173

Closed

feat(storybook): chromatic a11y testing #4180

Closed

chore: updating lint-staged file inheritance order #4193

Closed

castastrophe mentioned this pull request Oct 22, 2025

feat(badge): remove modifiers from the API [SWC-1264] #4283

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: restore undefined custom properties [part 4]#3473

fix: restore undefined custom properties [part 4]#3473
jawinn merged 6 commits into
spectrum-twofrom
jawinn/css-1086-s2-undefined-4

jawinn commented Jan 3, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 3, 2025 •

edited

Loading

assetcard

colorwheel

combobox

search

treeview

Uh oh!

5t3ph left a comment

Uh oh!

marissahuysentruyt left a comment •

edited

Loading

Uh oh!

marissahuysentruyt left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jawinn commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How and where has this been tested?

Validation steps

To-do list

Uh oh!

changeset-bot Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

File metrics

Summary

assetcard

colorwheel

combobox

search

treeview

Uh oh!

5t3ph left a comment

Choose a reason for hiding this comment

Uh oh!

marissahuysentruyt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marissahuysentruyt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jawinn commented Jan 3, 2025 •

edited

Loading

changeset-bot Bot commented Jan 3, 2025 •

edited

Loading

github-actions Bot commented Jan 3, 2025 •

edited

Loading

github-actions Bot commented Jan 3, 2025 •

edited

Loading

marissahuysentruyt left a comment •

edited

Loading

marissahuysentruyt left a comment •

edited

Loading