fix(*): define missing custom properties from theme directory by cdransf · Pull Request #3517 · adobe/spectrum-css

cdransf · 2025-01-21T20:55:30Z

Description

CSS-1084

fixes missing custom properties by transferring them from s2-foundations-redux

To-do list

I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨

This reverts commit 3d489fe.

changeset-bot · 2025-01-21T20:55:34Z

🦋 Changeset detected

Latest commit: 599fcc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@spectrum-css/infieldbutton	Patch
@spectrum-css/actionbutton	Patch
@spectrum-css/clearbutton	Patch
@spectrum-css/avatar	Patch
@spectrum-css/button	Patch
@spectrum-css/dialog	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-21T21:00:59Z

File metrics

Summary

Total size: 2.23 MB^*
Total change (Δ): 🔴 ⬆ 2.81 KB (0.12%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
actionbutton	23.50 KB	🔴 ⬆ 1.08 KB
avatar	6.52 KB	🟢 ⬇ 0.05 KB
button	30.25 KB	🔴 ⬆ 0.23 KB
clearbutton	6.18 KB	🔴 ⬆ 0.57 KB
dialog	15.00 KB	🟢 ⬇ 0.05 KB
infieldbutton	15.55 KB	🔴 ⬆ 0.79 KB

Details

actionbutton

Filename	Head	Compared to base
index.css	23.50 KB	🔴 ⬆ 1.08 KB (4.84%)
metadata.json	10.64 KB	🔴 ⬆ 0.14 KB (1.29%)

avatar

Filename	Head	Compared to base
index.css	6.52 KB	🟢 ⬇ 0.05 KB (-0.76%)
metadata.json	2.52 KB	🟢 ⬇ 0.06 KB (-2.27%)

button

Filename	Head	Compared to base
index.css	30.25 KB	🔴 ⬆ 0.23 KB (0.76%)
metadata.json	11.45 KB	-

clearbutton

Filename	Head	Compared to base
index.css	6.18 KB	🔴 ⬆ 0.57 KB (9.93%)
metadata.json	3.35 KB	🔴 ⬆ 0.08 KB (2.39%)

dialog

Filename	Head	Compared to base
index.css	15.00 KB	🟢 ⬇ 0.05 KB (-0.32%)
metadata.json	5.66 KB	🟢 ⬇ 0.04 KB (-0.77%)

infieldbutton

Filename	Head	Compared to base
index.css	15.55 KB	🔴 ⬆ 0.79 KB (5.25%)
metadata.json	7.22 KB	🔴 ⬆ 0.15 KB (2.09%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions · 2025-01-21T21:41:14Z

🚀 Deployed on https://pr-3517--spectrum-css.netlify.app

* fix(*): define missing custom properties from theme directory * fix(*): restore missing mods and tokens * fix(*): restore missing mod and update metadata * fix(*): restore missing mods and update metadata * fix(*): restore basebutton import * chore(*): update metadata This reverts commit 3d489fe. * fix(*): restore actionbutton staticwhite background color * chore(*): update metadata * chore: resolve conflict * fix(*): actionbutton emphasized + static conflict * fix(*): actionbutton restore missing mods * fix(*): actionbutton clean up mods; fix missing states * fix(*): actionbutton restore focus indicator mods * chore(*): remove unused theme files

…ies from theme directory (#3517) * restore missing mods and tokens * restore missing mod and update metadata

cdransf added 12 commits January 21, 2025 12:46

fix(*): define missing custom properties from theme directory

2cd43c3

fix(*): restore missing mods and tokens

46c142a

fix(*): restore missing mod and update metadata

4a4f669

fix(*): restore missing mods and update metadata

2023186

fix(*): restore basebutton import

ad7c5f9

chore(*): update metadata

4251099

This reverts commit 3d489fe.

fix(*): restore actionbutton staticwhite background color

3ef47b5

chore(*): update metadata

375490d

chore: resolve conflict

c816b1a

fix(*): actionbutton emphasized + static conflict

10f3579

fix(*): actionbutton restore missing mods

87a289b

fix(*): actionbutton clean up mods; fix missing states

46faf77

fix(*): actionbutton restore focus indicator mods

29a01a9

cdransf force-pushed the cdransf/undefined-token-fixes-css-1084-redux branch from 599fcc0 to 29a01a9 Compare January 21, 2025 20:56

cdransf requested review from castastrophe and pfulton January 21, 2025 20:57

chore(*): remove unused theme files

50c7217

pfulton approved these changes Jan 21, 2025

View reviewed changes

cdransf merged commit 7582c1f into spectrum-two Jan 21, 2025

cdransf deleted the cdransf/undefined-token-fixes-css-1084-redux branch January 21, 2025 21:48

github-actions Bot mentioned this pull request Jan 21, 2025

chore: release (next) #3513

Merged

castastrophe pushed a commit that referenced this pull request Feb 11, 2025

fix(actionbutton,avatar,button,dialog): define missing custom propert…

ea76c41

…ies from theme directory (#3517) * restore missing mods and tokens * restore missing mod and update metadata

castastrophe pushed a commit that referenced this pull request Feb 24, 2025

fix(actionbutton,avatar,button,dialog): define missing custom propert…

aa2ac87

…ies from theme directory (#3517) * restore missing mods and tokens * restore missing mod and update metadata

castastrophe pushed a commit that referenced this pull request Feb 24, 2025

fix(actionbutton,avatar,button,dialog): define missing custom propert…

d43d76d

…ies from theme directory (#3517) * restore missing mods and tokens * restore missing mod and update metadata

castastrophe pushed a commit that referenced this pull request Feb 25, 2025

fix(actionbutton,avatar,button,dialog): define missing custom propert…

91d2cf4

…ies from theme directory (#3517) * restore missing mods and tokens * restore missing mod and update metadata

castastrophe mentioned this pull request Apr 15, 2025

feat(tokens,card): update to @adobe/spectrum-tokens@13.3.0 #3669

Merged

12 tasks

This was referenced May 16, 2025

chore(swatch,menu,swatchgroup): fix reverted metadata assets #3752

Merged

chore: merge latest updates from main #3777

Merged

castastrophe mentioned this pull request Jul 25, 2025

ci: chromatic runs for S2 [CSS-1233] #4070

Merged

3 tasks

castastrophe mentioned this pull request Aug 6, 2025

fix: minor linting updates #4113

Merged

11 tasks

This was referenced Aug 27, 2025

chore(popover): wrapper placement in story #4173

Closed

feat(storybook): chromatic a11y testing #4180

Closed

chore: updating lint-staged file inheritance order #4193

Closed

castastrophe mentioned this pull request Oct 22, 2025

feat(badge): remove modifiers from the API [SWC-1264] #4283

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(*): define missing custom properties from theme directory#3517

fix(*): define missing custom properties from theme directory#3517
cdransf merged 14 commits into
spectrum-twofrom
cdransf/undefined-token-fixes-css-1084-redux

cdransf commented Jan 21, 2025

Uh oh!

changeset-bot Bot commented Jan 21, 2025

Uh oh!

github-actions Bot commented Jan 21, 2025 •

edited

Loading

actionbutton

avatar

button

clearbutton

dialog

infieldbutton

Uh oh!

github-actions Bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cdransf commented Jan 21, 2025

Description

To-do list

Uh oh!

changeset-bot Bot commented Jan 21, 2025

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

File metrics

Summary

actionbutton

avatar

button

clearbutton

dialog

infieldbutton

Uh oh!

github-actions Bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jan 21, 2025 •

edited

Loading