feat(contextualhelp): add mod to allow max-width#3523
Conversation
🦋 Changeset detectedLatest commit: b7e1c04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-3523--spectrum-css.netlify.app |
File metricsSummaryTotal size: 2.25 MB*
contextualhelp
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
a5ef3a6 to
db15e38
Compare
db15e38 to
a83b27f
Compare
a83b27f to
70cf597
Compare
marissahuysentruyt
left a comment
There was a problem hiding this comment.
@TarunAdobe Nice work on this! I requested a few minor changes, but overall this is looking really good.
How would you feel about adding some documentation for these new stories? Even something pretty simple, like what you have in the changeset, would be nice.
Example docs: (feel free to expand on this- you can probably do a better job than me!)
"In order to further customize the contextual help popover, implementations can set --mod-spectrum-contextual-help-popover-maximum-width to their desired max width."
It might give users a little head start of figuring out how to customize this component.
|
@castastrophe @TarunAdobe oh I was just thinking- do we need to run VRTs on this branch before it merges? Since we updated the body content of the stories, I think Chromatic would flag it, right? |
Don't want to hold up merging this! Quickly glancing, it's looking good!
Description
Added a
--modproperty to allow consumers to set amax-widthon the contextual help component.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list