Skip to content

feat(divider): S2 migration#3557

Merged
cdransf merged 1 commit into
spectrum-twofrom
cdransf/s2-divider-migration
Feb 26, 2025
Merged

feat(divider): S2 migration#3557
cdransf merged 1 commit into
spectrum-twofrom
cdransf/s2-divider-migration

Conversation

@cdransf
Copy link
Copy Markdown
Member

@cdransf cdransf commented Feb 13, 2025

Description

CSS-708

This migrates the divider component to S2. Custom properties have been remapped and updated per the design spec.

New properties

--spectrum-divider-horizontal-minimum-width
--spectrum-divider-vertical-minimum-height

New mods

--mod-divider-inline-minimum-size
--mod-divider-block-minimum-size

Removed mods

--mod-divider-background-color-large-static-black
--mod-divider-background-color-large-static-white
--mod-divider-background-color-medium-static-black
--mod-divider-background-color-medium-static-white
--mod-divider-background-color-small-static-black
--mod-divider-background-color-small-static-white

Additions

This adds new minimum width and height tokens for the divider and the minDimensionValues arg has been removed in favor of these tokens and the rules with which they're applied.

The default size for the Storybook control has been changed to medium (the new default size for the component). All sizes are now displayed for the static color variants in the docs.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Feb 13, 2025
@cdransf cdransf self-assigned this Feb 13, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 99e67ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@spectrum-css/divider Major
@spectrum-css/alertbanner Major
@spectrum-css/alertdialog Major
@spectrum-css/dialog Major
@spectrum-css/menu Major
@spectrum-css/popover Major
@spectrum-css/tray Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch from ed77498 to 7883943 Compare February 13, 2025 21:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2025

File metrics

Summary

Total size: 1.37 MB*

Package Size Minified Gzipped
divider 2.85 KB 2.71 KB 0.84 KB

divider

Filename Head Minified Gzipped Compared to base
index.css 2.85 KB 2.71 KB 0.84 KB 🟢 ⬇ 0.37 KB
metadata.json 1.44 KB - - 🟢 ⬇ 0.23 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2025

🚀 Deployed on https://pr-3557--spectrum-css.netlify.app

],
"modifiers": [
"--mod-divider-background-color",
"--mod-divider-background-color-large-static-black",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This drops deprecated color styles in favor of the tokens specified by design — I'm not sure if we should alias the raw color tokens to our own and — if so — what naming scheme to use? Doing so would allow us to provide mods for them, but I'm not sure if that's necessary.

@castastrophe castastrophe added the S2 Spectrum 2 label Feb 18, 2025
@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch 2 times, most recently from 21cf5df to 4eb24b0 Compare February 21, 2025 23:42
@castastrophe castastrophe force-pushed the spectrum-two branch 5 times, most recently from d5e72d4 to 0f14273 Compare February 24, 2025 22:39
@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch from 4eb24b0 to e811287 Compare February 25, 2025 00:17
@aramos-adobe aramos-adobe self-requested a review February 25, 2025 18:06
Copy link
Copy Markdown
Contributor

@aramos-adobe aramos-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A++ , really well documented and I love the simplification of the template and index.css files!

Copy link
Copy Markdown
Contributor

@5t3ph 5t3ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch from 193097b to 99e67ba Compare February 26, 2025 22:46
@cdransf cdransf merged commit c6836fb into spectrum-two Feb 26, 2025
@cdransf cdransf deleted the cdransf/s2-divider-migration branch February 26, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review S2 Spectrum 2 size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants