feat(divider): S2 migration#3557
Conversation
🦋 Changeset detectedLatest commit: 99e67ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ed77498 to
7883943
Compare
File metricsSummaryTotal size: 1.37 MB*
divider
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3557--spectrum-css.netlify.app |
| ], | ||
| "modifiers": [ | ||
| "--mod-divider-background-color", | ||
| "--mod-divider-background-color-large-static-black", |
There was a problem hiding this comment.
This drops deprecated color styles in favor of the tokens specified by design — I'm not sure if we should alias the raw color tokens to our own and — if so — what naming scheme to use? Doing so would allow us to provide mods for them, but I'm not sure if that's necessary.
21cf5df to
4eb24b0
Compare
d5e72d4 to
0f14273
Compare
4eb24b0 to
e811287
Compare
aramos-adobe
left a comment
There was a problem hiding this comment.
A++ , really well documented and I love the simplification of the template and index.css files!
3499231 to
ad861d0
Compare
e811287 to
193097b
Compare
193097b to
99e67ba
Compare
Description
CSS-708This migrates the
dividercomponent to S2. Custom properties have been remapped and updated per the design spec.New properties
New mods
Removed mods
Additions
This adds new minimum width and height tokens for the divider and the
minDimensionValuesarg has been removed in favor of these tokens and the rules with which they're applied.The default size for the Storybook control has been changed to
medium(the new default size for the component). All sizes are now displayed for the static color variants in the docs.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
To-do list