chore(dialog): use isOpen type for open control#3562
Merged
marissahuysentruyt merged 1 commit intoFeb 17, 2025
Conversation
🦋 Changeset detectedLatest commit: f78350f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🚀 Deployed on https://pr-3562--spectrum-css.netlify.app |
Contributor
File metricsSummaryTotal size: 1.42 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
jawinn
approved these changes
Feb 17, 2025
castastrophe
pushed a commit
that referenced
this pull request
Feb 24, 2025
castastrophe
pushed a commit
that referenced
this pull request
Feb 24, 2025
castastrophe
pushed a commit
that referenced
this pull request
Feb 25, 2025
12 tasks
This was referenced May 16, 2025
3 tasks
11 tasks
This was referenced Aug 27, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR correctly implements the
isOpenshared type on the dialog pages. This should correct the display of theisOpencontrol.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
isOpen).Regression testing
Validate:
Screenshots
Before 🚫


After ✅

To-do list