Skip to content

fix(tooltip): restore negative and informative semantic variants#3641

Merged
cdransf merged 3 commits into
spectrum-twofrom
cdransf/s2-tooltip-semantic-variants
Apr 2, 2025
Merged

fix(tooltip): restore negative and informative semantic variants#3641
cdransf merged 3 commits into
spectrum-twofrom
cdransf/s2-tooltip-semantic-variants

Conversation

@cdransf
Copy link
Copy Markdown
Member

@cdransf cdransf commented Mar 25, 2025 •
edited
Loading

Description

This restores the negative and informative tooltip semantic variant styles, story controls and test cases. Icons have been removed for all variants as they are not present in the specifications provided by design.

Restored mods

--mod-tooltip-background-color-informative
--mod-tooltip-background-color-negative"

Validation steps

  1. Open the Storybook link for this PR.
  2. Navigate to the Default story for the tooltip component.
  3. Select the informative and negative tooltip styles in controls and verify that they match the Figma design(s).

Screenshots

Screenshot 2025-03-25 at 10 39 32 AM

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: dfcbd61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/tooltip Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf force-pushed the cdransf/s2-tooltip-semantic-variants branch from f6a7e85 to c215a47 Compare March 25, 2025 17:42
@cdransf cdransf marked this pull request as ready for review March 25, 2025 17:43
@cdransf cdransf self-assigned this Mar 25, 2025
@cdransf cdransf added size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025 •
edited
Loading

File metrics

Summary

Total size: 1.37 MB*

Package Size Minified Gzipped
tooltip 31.95 KB 30.70 KB 3.11 KB

tooltip

Filename Head Minified Gzipped Compared to base
index.css 31.95 KB 30.70 KB 3.11 KB 🔴 ⬆ 1.17 KB
metadata.json 20.57 KB - - 🔴 ⬆ 0.37 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025 •
edited
Loading

🚀 Deployed on https://pr-3641--spectrum-css.netlify.app

@cdransf cdransf closed this Mar 25, 2025
@cdransf cdransf reopened this Mar 25, 2025
@cdransf cdransf force-pushed the cdransf/s2-tooltip-semantic-variants branch from c215a47 to d961f08 Compare March 27, 2025 17:49
marissahuysentruyt
marissahuysentruyt requested changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks for getting these variants back in!

Could you update the test file please? Looks like we still have the positive variant captured, but we can delete it!

Screenshot 2025-04-01 at 2 40 31 PM

Comment thread components/tooltip/index.css Outdated
marissahuysentruyt
marissahuysentruyt approved these changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great!

Just a note that the commit when we squash this down, should probably be a fix, since we're changing CSS, but not introducing a breaking change. Cassondra mentioned once that if there's CSS changes, we should label our commits as fix or feat.

Comment thread components/tooltip/index.css
@import "@spectrum-css/commons/overlay.css";

.spectrum-Tooltip {
--spectrum-tooltip-backgound-color-default-neutral: var(--spectrum-neutral-subdued-background-color-default);
Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wwe-i-sentence-you-to-deletion

@cdransf cdransf force-pushed the cdransf/s2-tooltip-semantic-variants branch 2 times, most recently from 616a05a to cfa34ed Compare April 1, 2025 22:34
@cdransf cdransf changed the title chore(tooltip): restore negative and informative semantic variants fix(tooltip): restore negative and informative semantic variants Apr 2, 2025
@cdransf cdransf force-pushed the cdransf/s2-tooltip-semantic-variants branch from cfa34ed to dfcbd61 Compare April 2, 2025 15:19
castastrophe
castastrophe approved these changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for this update and documenting it so well!

Comment thread .changeset/stale-pans-carry.md
"@spectrum-css/tooltip": minor
---

#### S2: restore negative and informative semantic variants
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the heading levels 🥳

@cdransf cdransf merged commit 0b730ea into spectrum-two Apr 2, 2025
@cdransf cdransf deleted the cdransf/s2-tooltip-semantic-variants branch April 2, 2025 15:43
@castastrophe castastrophe mentioned this pull request Apr 15, 2025
Merged
12 tasks
@castastrophe castastrophe mentioned this pull request May 16, 2025
Merged
6 tasks
@castastrophe castastrophe mentioned this pull request May 19, 2025
Merged
2 tasks
@castastrophe castastrophe mentioned this pull request Jul 25, 2025
Merged
3 tasks
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
Merged
11 tasks
This was referenced Aug 27, 2025
Closed
Closed
Closed
@castastrophe castastrophe mentioned this pull request Oct 22, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marissahuysentruyt marissahuysentruyt marissahuysentruyt approved these changes

@rise-erpelding rise-erpelding Awaiting requested review from rise-erpelding

+1 more reviewer

@castastrophe castastrophe castastrophe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cdransf cdransf

Labels

ready-for-review size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. skip_vrt Add to a PR to skip running VRT (but still pass the action)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdransf @castastrophe @marissahuysentruyt