feat(actionbar): new s2 migration #3657
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| "@spectrum-css/actionbar": major | ||
| --- | ||
|
|
||
| ### Actionbar S2 Migration | ||
|
|
||
| Action bar now has some updated colors, corner radius, and icons. There's a new look to the default and emphasized variants. | ||
|
|
||
| The emphasized has changed from an `accent` background color to a `neutral` background color. In light mode, the clear button and action buttons are `staticWhite` and in dark mode they are `staticBlack`. | ||
|
|
||
| #### New tokens | ||
|
|
||
| `--spectrum-actionbar-emphasized-actionbutton-label-color` | ||
| `--spectrum-actionbar-emphasized-icon-color` | ||
| `--spectrum-actionbar-minimum-width` | ||
| `--spectrum-actionbar-spacing-label-to-action-group` | ||
| `--spectrum-actionbar-spacing-action-group-edge` | ||
| `--spectrum-actionbar-close-button-to-counter` | ||
|
|
||
| #### New mods | ||
|
|
||
| `--mod-actionbar-minimum-width` | ||
| `--mod-actionbar-spacing-action-group-edge` | ||
| `--mod-actionbar-spacing-label-to-action-group` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,42 +12,36 @@ | |
| */ | ||
|
|
||
| .spectrum-ActionBar { | ||
| /* Layout */ | ||
| --spectrum-actionbar-height: var(--spectrum-action-bar-height); | ||
| --spectrum-actionbar-minimum-width: var(--spectrum-action-bar-minimum-width); | ||
| --spectrum-actionbar-corner-radius: var(--spectrum-corner-radius-medium-size-extra-large); | ||
| --spectrum-actionbar-spacing-label-to-action-group: var(--spectrum-action-bar-label-to-action-group-area); | ||
| --spectrum-actionbar-spacing-padding-inline: var(--spectrum-action-bar-edge-to-content-area); | ||
| --spectrum-actionbar-spacing-top-area: var(--spectrum-action-bar-top-to-content-area); | ||
| --spectrum-actionbar-spacing-bottom-area: var(--spectrum-action-bar-bottom-to-content-area); | ||
| --spectrum-actionbar-close-button-to-counter: var(--spectrum-action-bar-close-button-to-counter); | ||
| /* stylelint-disable-next-line spectrum-tools/no-unused-custom-properties -- defines the field label mod */ | ||
| --spectrum-actionbar-item-counter-line-height: var(--spectrum-line-height-100); | ||
|
Contributor
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment. @aramos-adobe I think this got flagged because we're only setting |
||
| --spectrum-actionbar-item-counter-color: var(--spectrum-neutral-content-color-default); | ||
|
|
||
| /* colors - applied to popover */ | ||
| --spectrum-actionbar-popover-background-color: var(--spectrum-background-elevated-color); | ||
| --spectrum-actionbar-popover-border-color: var(--spectrum-action-bar-border-color); | ||
|
|
||
| /* spacing of action bar bottom and horizontal outer edge */ | ||
| --spectrum-actionbar-spacing-outer-edge: var(--spectrum-spacing-300); | ||
|
|
||
| /* drop shadow */ | ||
| --spectrum-actionbar-shadow-horizontal: var(--spectrum-drop-shadow-elevated-x); | ||
| --spectrum-actionbar-shadow-vertical: var(--spectrum-drop-shadow-elevated-y); | ||
| --spectrum-actionbar-shadow-blur: var(--spectrum-drop-shadow-elevated-blur); | ||
| --spectrum-actionbar-shadow-color: var(--spectrum-drop-shadow-elevated-color); | ||
|
|
||
| &.spectrum-ActionBar--emphasized { | ||
| --spectrum-actionbar-item-counter-color: var(--spectrum-gray-25); | ||
| --spectrum-actionbar-popover-background-color: var(--spectrum-neutral-content-color-default); | ||
| } | ||
|
|
||
| /* cjk language support for item counter */ | ||
| &:lang(ja), | ||
|
|
@@ -57,17 +51,6 @@ | |
| } | ||
| } | ||
|
|
||
| /* ActionBar is outer wrapper with nested popover component within */ | ||
| .spectrum-ActionBar { | ||
| /* creates horizontal spacing to edge */ | ||
|
|
@@ -94,11 +77,12 @@ | |
| .spectrum-ActionBar-popover { | ||
| /* popover is ActionBar height */ | ||
| block-size: var(--mod-actionbar-height, var(--spectrum-actionbar-height)); | ||
| min-inline-size: var(--mod-actionbar-minimum-width, var(--spectrum-actionbar-minimum-width)); | ||
| box-sizing: border-box; | ||
| inline-size: 100%; | ||
| margin: auto; | ||
| padding-inline: var(--mod-actionbar-spacing-action-group-edge, var(--spectrum-actionbar-spacing-padding-inline)); | ||
| padding-block: var(--mod-actionbar-spacing-top-area, var(--spectrum-actionbar-spacing-top-area)) var(--mod-actionbar-spacing-bottom-area, var(--spectrum-actionbar-spacing-bottom-area)); | ||
|
|
||
| /* Be relative so our width can be restricted */ | ||
| position: relative; | ||
|
|
@@ -115,27 +99,15 @@ | |
| /* inner layout of content items */ | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; | ||
| } | ||
|
|
||
| /* item counter */ | ||
| .spectrum-FieldLabel { | ||
| --mod-fieldlabel-font-size: var(--spectrum-action-bar-counter-font-size); | ||
| --mod-fieldlabel-line-height: var(--spectrum-actionbar-item-counter-line-height); | ||
| color: var(--mod-actionbar-item-counter-color, var(--spectrum-actionbar-item-counter-color)); | ||
| padding-inline-start: var(--mod-actionbar-close-button-to-counter, var(--spectrum-actionbar-close-button-to-counter)); | ||
|
|
||
| /* cjk language support */ | ||
| &:lang(ja), | ||
|
|
@@ -147,26 +119,9 @@ | |
|
|
||
| /* action group */ | ||
| .spectrum-ActionGroup { | ||
| /* align to end by default */ | ||
| margin-inline-start: auto; | ||
| padding-inline-start: var(--mod-actionbar-spacing-label-to-action-group, var(--spectrum-actionbar-spacing-label-to-action-group)); /* space between label and action group */ | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -184,3 +139,10 @@ | |
| .spectrum-ActionBar--flexible .spectrum-ActionBar-popover { | ||
| inline-size: auto; | ||
| } | ||
|
|
||
| /* windows high contrast mode */ | ||
| @media (forced-colors: active) { | ||
| .spectrum-ActionBar { | ||
| --highcontrast-actionbar-popover-border-color: CanvasText; | ||
| } | ||
| } | ||
|
Collaborator
There was a problem hiding this comment. @aramos-adobe Could we add
Collaborator
There was a problem hiding this comment. We could also add to the
Collaborator
There was a problem hiding this comment. @aramos-adobe Thanks so much for adding the migrated status! Once your branch is rebased, we should get a migrated badge now :) 
If you could also add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.