chore(combobox, datepicker,et all): add displayLabel arg

[marissahuysentruyt]

Description

After rebasing the search field migration branch, I noticed that the icons were placed awkwardly. I realized that the nested textfield in my search component was just missing a displayLabel: false argument. That arg was updated in the textfield S2 migration, to be set to true on default (based on guidance that "a textfield should always have a label"), but because search isn't utilizing the field label that ships with textfield, that arg should be set to false. Without the displayLabel arg set to false, the textfield was still rendering an additional, empty field label component, and offsetting the icon & button within search.

After scanning the repo, the following components needed similar displayValue: false args:
combobox, datepicker, form, pagination, stepper

Jira/Specs

CSS-1174

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

• Pull down the branch to run locally or visit the deploy preview.
• Navigate to each component's docs page. Ensure that nothing looks "broken" and most of the styles are acceptable.
  • combobox (the picker button and validation icons)
  • date picker (the picker button and validation icons)
  • form (the stepper should be fixed, as well as the alignment of the form labels to their textfields)
  • pagination (specifically the explicit variant)
  • search (the search icon and close button)
  • stepper/number field (the infield buttons)
• By comparison, compare the fixed components to a recent deploy preview for spectrum-two (these components do look broken):
  • combobox
  • date picker
  • form
  • pagination
  • search
  • stepper/number field

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

2. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Before 🚫
combobox

datepicker

search

pagination

form

stepper

After ✅
combobox

datepicker

search

pagination

form

stepper

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• If my change impacts other components, I have tested to make sure they don't break.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

⚠️ No Changeset found

Latest commit: 68cc237

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

🚀 Deployed on https://pr-3660--spectrum-css.netlify.app

[github-actions]

File metrics

Summary

Total size: 1.38 MB^*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[rise-erpelding]

This definitely feels like the simpler solution and works nicely.

It is interesting to note though, looking through the guidelines they say "text fields should always have a label" and then in something like combobox, the field label can exist but the markup is outside .spectrum-Textfield (and .spectrum-Combobox for that matter).