chore: merge latest from main#3671
Conversation
castastrophe
added
size-2 S
|
|
🚀 Deployed on https://pr-3671--spectrum-css.netlify.app |
File metricsSummaryTotal size: 1.37 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
We've lost a couple things in the MDX docs removal for story and icon on main, that we can update in a follow-up PR:
- Button "Docs" page is missing; I think this just needs "!autodocs" removed from the story default export.
- Icon docs lost a few additions from its MDX in spectrum-two, “For a full list of all icons within this set...” text/links
We'll also need to reorganize and exclude new stories as necessary on the Docs page for Icon in that follow-up, as there are new stories that should be hidden and a few stories need a title change to organize them better.
Edit: as discussed, I'll add a commit to update that on this PR.
jawinn
dismissed
their stale review
Adding Docs tweaks to this PR and someone else will need to review.
rise-erpelding
left a comment
rise-erpelding
left a comment
There was a problem hiding this comment.
This looks great! I did check over the button and icon docs pages and they incorporate the needed info from main and maintain any new icons documentation that's more specific to S2.
In the switch back to autodocs from a custom MDX, some newly added stories for S2 needed to be hidden for the Docs page, and some story titles needing renaming to keep related stories in order.
castastrophe
force-pushed
the
chore-merge-latest-main
branch
from
a3cd891 to
81d8313
Compare
3 participants
Description
Pull in the latest updates from the main branch to benefit the spectrum 2 development.
Testing and validation
Expect no regressions.