-
Notifications
You must be signed in to change notification settings - Fork 210
fix(button,statuslight,picker,etc): address regressions in migrated components #3687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marissahuysentruyt
merged 13 commits into
spectrum-two
from
marissahuysentruyt/css-1175-regressions-in-migrated-components
May 6, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2a5d33a
fix(button): fix s2 regressions
marissahuysentruyt 770f68b
chore(button): add changeset
marissahuysentruyt 142df1a
fix(switch): fix regressions
marissahuysentruyt 8d27661
chore(switch): add changeset
marissahuysentruyt 44b3f3c
fix(statuslight): correct font-family token
marissahuysentruyt 48a46ce
fix(statuslight): adds focus ring color token
marissahuysentruyt ac304ba
fix(picker): fix regressions
marissahuysentruyt 5457eae
chore(link,picker,statuslight,switch): create changeset
marissahuysentruyt 97b483f
docs(colorarea): pass focus to color handle in template
marissahuysentruyt 9fd0ac9
fix(floatingactionbutton): use color property instead of fill for icon
marissahuysentruyt 795142c
fix(logicbutton): defines border style
marissahuysentruyt 73d95d0
chore: separate changesets for each component
marissahuysentruyt 1de55cf
refactor(switch): change animation token name
marissahuysentruyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@spectrum-css/switch": patch | ||
| --- | ||
|
|
||
| ### S2 switch fixes | ||
|
|
||
| This work addresses minor regressions in the Switch component. Animation tokens are reimplemented and their usage updated within the style definitions. | ||
|
|
||
| Reference: | ||
|
|
||
| - [S2 switch migration](https://github.com/adobe/spectrum-css/pull/2651) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@spectrum-css/statuslight": patch | ||
| --- | ||
|
|
||
| ### S2 status light fix | ||
|
|
||
| This work removes the reference to `default-font-family` in favor for `sans-font-family-stack` to ensure the status light's font renders appropriately for web. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@spectrum-css/link": patch | ||
| --- | ||
|
|
||
| ### S2 link fix | ||
|
|
||
| This work adds the static color focus ring tokens to links (so that static white and static black links do _not_ have the usual blue focus ring). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@spectrum-css/logicbutton": patch | ||
| --- | ||
|
|
||
| ### S2 logic button fix | ||
|
|
||
| Adds `border-style: solid` to the styles to avoid a 3D effect on the border. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@spectrum-css/floatingactionbutton": patch | ||
| --- | ||
|
|
||
| ## S2 floating action button fix | ||
|
|
||
| Opts to use the color property as opposed to fill for the icon. This correctly passes the floating action button icon colors to the component, to override the fill property style that is set on the embedded `.spectrum-Icon`. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the detailed changesets ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| "@spectrum-css/button": patch | ||
| --- | ||
|
|
||
| ### S2 button fixes | ||
|
castastrophe marked this conversation as resolved.
|
||
|
|
||
| This work addresses some regressions noticed in the migrated S2 button. Mainly, the borders were gray where they were not supposed to be. Most of the changes are to ensure that the correct S2 tokens are being used appropriately in the styles and button follows the S2 design specs. | ||
|
|
||
| Additionally, there was some missing style support for the `.spectrum-Button--noWrap` option, so this work reimplements a "no wrapping" option for button components, and removes some of the repetitiveness in the no wrap test cases and story. | ||
|
|
||
| PRs used as reference: | ||
|
|
||
| - [S2 button migration](https://github.com/adobe/spectrum-css/pull/2600) | ||
| - [Add text wrapping option](https://github.com/adobe/spectrum-css/pull/3086) | ||
| - [PostCSS plugin updates/fixes](https://github.com/adobe/spectrum-css/pull/3502) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "@spectrum-css/picker": patch | ||
| --- | ||
|
|
||
| ### S2 picker fixes | ||
|
|
||
| This work addresses some regressions noticed in the migrated S2 picker component. Mainly, S2 border colors were fixed (most of them are transparent, including disabled). | ||
|
|
||
| PRs used as reference: | ||
|
|
||
| - [Picker docs to storybook migration](https://github.com/adobe/spectrum-css/pull/3200) | ||
| - [S2 picker migration](https://github.com/adobe/spectrum-css/pull/2697) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.