-
Notifications
You must be signed in to change notification settings - Fork 210
feat(alert dialog): S2 migration #3725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3a9e578
feat(alert dialog): s2 migration
cdransf dda0961
chore(alert dialog): add vertical button display test + story
cdransf 8c4db31
fix(alert dialog): adjust treatment to match designs for error + warning
cdransf 798baa1
fix(alert dialog): add vertical button arrangement usage notes to story
cdransf 3c6810f
chore(alert dialog): add overflow story + scroll description
cdransf 4c2077d
fix(alert dialog): add inline-size: 100% to spectrum-AlertDialog-grid…
cdransf b723ad6
chore(alert dialog): cleanup for stories, templates and styles
cdransf 0c646ed
fix(alert dialog): correct figma link in story to point to proper com…
cdransf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| --- | ||
| "@spectrum-css/alertdialog": major | ||
| --- | ||
|
|
||
| #### S2 migration for alert dialog | ||
|
|
||
| This migrates the `alert dialog` component to the latest Spectrum 2 designs. Custom properties have been remapped and added per the design specification. | ||
|
|
||
| The icon in the dialog header has been moved from the right side to the left. | ||
|
|
||
| The dialog divider has been removed. | ||
|
|
||
| Primary button style has been updated to filled. | ||
|
|
||
| The following variants remain supported: | ||
|
|
||
| - Confirmation | ||
| - Information | ||
| - Destructive | ||
| - Warning (with `AlertDiamond` icon) | ||
| - Error (with `AlertTriangle` icon) | ||
|
|
||
| Dialog buttons may be displayed either horizontally or vertically. | ||
|
|
||
| ##### Removed custom properties | ||
|
|
||
| `--spectrum-alert-dialog-description-to-buttons` | ||
| `--spectrum-alert-dialog-divider-to-description` | ||
| `--spectrum-alert-dialog-padding` | ||
| `--spectrum-alert-dialog-title-size` | ||
| `--spectrum-alert-dialog-title-to-divider` | ||
| `--spectrum-alert-dialog-title-to-icon` | ||
|
|
||
| ##### New custom properties | ||
|
|
||
| `--spectrum-alert-dialog-background-color` | ||
| `--spectrum-alert-dialog-corner-radius` | ||
| `--spectrum-alert-dialog-description-font-size` | ||
| `--spectrum-alert-dialog-description-to-button-group` | ||
| `--spectrum-alert-dialog-edge-to-content` | ||
| `--spectrum-alert-dialog-heading-size` | ||
| `--spectrum-alert-dialog-title-to-description` | ||
|
|
||
| ##### Removed mods | ||
|
|
||
| `--mod-alert-dialog-body-font-size` | ||
| `--mod-alert-dialog-description-to-buttons` | ||
| `--mod-alert-dialog-divider-to-description` | ||
| `--mod-alert-dialog-padding` | ||
| `--mod-alert-dialog-title-to-divider` | ||
| `--mod-alert-dialog-title-to-icon` | ||
|
|
||
| ##### New mods | ||
|
|
||
| `--mod-alert-dialog-background-color` | ||
| `--mod-alert-dialog-corner-radius` | ||
| `--mod-alert-dialog-description-content-size` | ||
| `--mod-alert-dialog-description-to-button-group` | ||
| `--mod-alert-dialog-edge-to-content` | ||
| `--mod-alert-dialog-heading-size` | ||
| `--mod-alert-dialog-minimum-title-to-icon` | ||
| `--mod-alert-dialog-title-to-description` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.