feat(badge): S2 migration#3740
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 469910e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
File metricsSummaryTotal size: 1.41 MB*
badge
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
Contributor
|
🚀 Deployed on https://pr-3740--spectrum-css.netlify.app |
Member
|
This looks awesome! Validation steps check out, nothing looks out of place in the token and mod updates and the changes look great in dark mode and WHC as well. The only change I'd consider would be to highlight the new tokens in the changelog. ✨ |
cdransf
approved these changes
May 15, 2025
…ctrum-css into seckles/css-1033-s2-badge
…ctrum-css into seckles/css-1033-s2-badge
2 tasks
3 tasks
11 tasks
This was referenced Aug 27, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates the base Badge component to S2 designs, but does not include the "Notification" or "Highlight" types.
New mods
New mods added for each new color, as well as for the style-related application of each valid color, ex.
--mod-badge-subtle-background-color-accentand--mod-badge-outline-border-color-informative.Also added for the default
--mod-badge-border-colorand--mod-badge-border-widthHow and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Token specs
Regression testing
Validate:
Screenshots
To-do list