fix(link): fixes keyboard focus shift by changing padding to outline-offset#3861
Merged
Conversation
cdransf
requested review from
5t3ph,
aramos-adobe,
marissahuysentruyt and
rise-erpelding
cdransf
added
size-3 M
🦋 Changeset detectedLatest commit: 67f7e72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🚀 Deployed on https://pr-3861--spectrum-css.netlify.app |
Contributor
File metricsSummaryTotal size: 1.42 MB*
link
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
aramos-adobe
approved these changes
May 28, 2025
Contributor
aramos-adobe
left a comment
aramos-adobe
left a comment
There was a problem hiding this comment.
Tested it on other components:
- Accordion
- Inline Alert
- Contextual Help
- Well
No more layout shifts ⭐️ great use of outline-offset
marissahuysentruyt
approved these changes
May 28, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@spectrum-css/link": minor | |||
Collaborator
There was a problem hiding this comment.
Personally, I'd probably just call this a patch, since we categorized it as bug. I'll leave it up to you though.
3 tasks
11 tasks
This was referenced Aug 27, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation with padding would cause the component to shift when focused using the keyboard. Replacing
paddingwithoutline-offsetresolves this issue.How and where has this been tested?
Verified locally in Storybook.
Validation steps
linkcomponent docs page.To-do list