chore(swatch): updates the add swatch icon to use the ui rather than workflow icon#3871
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 64a261d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rise-erpelding
requested changes
May 29, 2025
Collaborator
rise-erpelding
left a comment
rise-erpelding
left a comment
There was a problem hiding this comment.
Correct me if I'm wrong! I think this just needs a tiny sizing adjustment for XS!
Contributor
|
🚀 Deployed on https://pr-3871--spectrum-css.netlify.app |
Contributor
File metricsSummaryTotal size: 1.42 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
cdransf
force-pushed
the
cdransf/s2-swatch-icon-update
branch
from
abd75ac to
64a261d
Compare
cdransf
added
size-2 S
rise-erpelding
approved these changes
May 30, 2025
3 tasks
11 tasks
This was referenced Aug 27, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
swatchcomponent was originally migrated we only had theworkflowadd icon. This updates the component to use theuiicon now that the latter is available.To-do list