Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .changeset/public-facts-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
"@spectrum-css/taggroup": major
---

The Spectrum 2 version of Tag Group is a major change from its Spectrum 1 counterpart.

Major style changes include:

- Use of new tokens and custom properties for spacing tags. The method of spacing between tags has changed. Where previously tags were spaced using tokens to represent inline and block margins on each tag, tags are now spaced by tokens representing the gaps between tags.
- Rather than being a single size, Tag group now comes in t-shirt sizes: Small, medium, and large. These sizes should determine the sizes of the embedded components, but also the spacing between tags.
- Tag group can now accommodate a side label. To do so, it makes use of a grid layout.
- In order to match the layout in the spec, more embedded components besides Tag have been added. Field label, Help text, and Action button (quiet) components have been added to the Storybook implementation, and styles are set for these embedded components within the tag group layout.

In order to support the aforementioned spacing changes, the two mod properties for margin have been removed:

- `--mod-tag-group-item-margin-block`
- `--mod-tag-group-item-margin-inline`

Instead, please customize spacing between tags with:
Comment thread
rise-erpelding marked this conversation as resolved.

- `--mod-tag-group-block-tag-spacing`
- `--mod-tag-group-inline-tag-spacing`

These custom properties may need to be set to be double the previous margin values in order to achieve the same spacing.

To support custom spacing of the embedded components, several other new mod properties have been added:

- `--mod-tag-group-block-spacing-label-to-tags`
- `--mod-tag-group-inline-spacing-label-to-tags`
- `--mod-tag-group-spacing-help-text-to-tags`

To support the optional empty state (when there are no tags in the tag group), several passthroughs to modify the body typography text element have been added, including:

- `--mod-body-cjk-line-height`
- `--mod-body-font-size`
- `--mod-body-line-height`
- `--mod-body-margin-end`
- `--mod-body-margin-start`
55 changes: 49 additions & 6 deletions components/taggroup/dist/metadata.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,58 @@
{
"sourceFile": "index.css",
"selectors": [".spectrum-TagGroup", ".spectrum-TagGroup-item"],
"selectors": [
".spectrum-TagGroup",
".spectrum-TagGroup--sideLabel",
".spectrum-TagGroup--sideLabel .spectrum-TagGroup-actionButton",
".spectrum-TagGroup--sideLabel .spectrum-TagGroup-helpText",
".spectrum-TagGroup--sideLabel .spectrum-TagGroup-label",
".spectrum-TagGroup--sideLabel .spectrum-TagGroup-tags",
".spectrum-TagGroup--sizeL",
".spectrum-TagGroup--sizeS",
".spectrum-TagGroup-actionButton",
".spectrum-TagGroup-helpText",
".spectrum-TagGroup-label",
".spectrum-TagGroup-tags",
".spectrum-TagGroup:lang(ja)",
".spectrum-TagGroup:lang(ko)",
".spectrum-TagGroup:lang(zh)"
],
"modifiers": [
"--mod-tag-group-item-margin-block",
"--mod-tag-group-item-margin-inline"
"--mod-body-cjk-line-height",
"--mod-body-font-size",
"--mod-body-line-height",
"--mod-body-margin-end",
"--mod-body-margin-start",
"--mod-tag-group-block-spacing-label-to-tags",
"--mod-tag-group-block-tag-spacing",
"--mod-tag-group-inline-spacing-label-to-tags",
"--mod-tag-group-inline-tag-spacing",
"--mod-tag-group-spacing-help-text-to-tags"
],
"component": [
"--spectrum-tag-group-item-margin-block",
"--spectrum-tag-group-item-margin-inline"
"--spectrum-tag-group-block-spacing-label-to-tags",
"--spectrum-tag-group-block-tag-spacing",
"--spectrum-tag-group-inline-spacing-label-to-tags",
"--spectrum-tag-group-inline-tag-spacing",
"--spectrum-tag-group-spacing-help-text-to-tags"
],
"global": [
"--spectrum-cjk-line-height-100",
"--spectrum-component-bottom-to-text-100",
"--spectrum-component-bottom-to-text-200",
"--spectrum-component-bottom-to-text-75",
"--spectrum-component-top-to-text-100",
"--spectrum-component-top-to-text-200",
"--spectrum-component-top-to-text-75",
"--spectrum-field-label-to-component",
"--spectrum-font-size-100",
"--spectrum-font-size-200",
"--spectrum-font-size-75",
"--spectrum-help-text-to-component",
"--spectrum-line-height-100",
"--spectrum-spacing-100",
"--spectrum-spacing-200"
],
"global": ["--spectrum-spacing-75"],
"passthroughs": [],
"high-contrast": []
}
94 changes: 85 additions & 9 deletions components/taggroup/index.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Copyright 2024 Adobe. All rights reserved.
* Copyright 2025 Adobe. All rights reserved.
*
* This file is licensed to you under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. You may obtain a copy
Expand All @@ -12,17 +12,93 @@
*/

.spectrum-TagGroup {
--spectrum-tag-group-item-margin-block: var(--spectrum-spacing-75);
--spectrum-tag-group-item-margin-inline: var(--spectrum-spacing-75);
--spectrum-tag-group-inline-tag-spacing: var(--spectrum-spacing-200);
--spectrum-tag-group-block-tag-spacing: var(--spectrum-spacing-200);
--spectrum-tag-group-block-spacing-label-to-tags: var(--spectrum-field-label-to-component);
--spectrum-tag-group-inline-spacing-label-to-tags: var(--spectrum-spacing-200);
--spectrum-tag-group-spacing-help-text-to-tags: var(--spectrum-help-text-to-component);

/* passthroughs for body typography element in empty state */
--mod-body-line-height: var(--spectrum-line-height-100);
--mod-body-font-size: var(--spectrum-font-size-100);
--mod-body-margin-start: var(--spectrum-component-top-to-text-100);
--mod-body-margin-end: var(--spectrum-component-bottom-to-text-100);

&:lang(ja),
&:lang(zh),
&:lang(ko) {
--mod-body-cjk-line-height: var(--spectrum-cjk-line-height-100);
}
}

.spectrum-TagGroup--sizeS {
--spectrum-tag-group-inline-tag-spacing: var(--spectrum-spacing-100);
--spectrum-tag-group-block-tag-spacing: var(--spectrum-spacing-100);

/* passthroughs for body typography element in empty state */
--mod-body-font-size: var(--spectrum-font-size-75);
--mod-body-margin-start: var(--spectrum-component-top-to-text-75);
--mod-body-margin-end: var(--spectrum-component-bottom-to-text-75);
}

.spectrum-TagGroup--sizeL {
--spectrum-tag-group-inline-tag-spacing: var(--spectrum-spacing-200);
--spectrum-tag-group-block-tag-spacing: var(--spectrum-spacing-200);

/* passthroughs for body typography element in empty state */
--mod-body-font-size: var(--spectrum-font-size-200);
--mod-body-margin-start: var(--spectrum-component-top-to-text-200);
--mod-body-margin-end: var(--spectrum-component-bottom-to-text-200);
}

.spectrum-TagGroup {
display: grid;
grid-template-rows: auto auto auto auto;
}

.spectrum-TagGroup-tags {
display: inline-flex;
flex-wrap: wrap;
margin: 0;
padding: 0;
list-style: none;
column-gap: var(--mod-tag-group-inline-tag-spacing, var(--spectrum-tag-group-inline-tag-spacing));
row-gap: var(--mod-tag-group-block-tag-spacing, var(--spectrum-tag-group-block-tag-spacing));
margin-block-end: var(--mod-tag-group-block-tag-spacing, var(--spectrum-tag-group-block-tag-spacing));
}

.spectrum-TagGroup-label {
margin-block-end: var(--mod-tag-group-block-spacing-label-to-tags, var(--spectrum-tag-group-block-spacing-label-to-tags));
}

.spectrum-TagGroup-item {
margin-block: var(--mod-tag-group-item-margin-block, var(--spectrum-tag-group-item-margin-block));
margin-inline: var(--mod-tag-group-item-margin-inline, var(--spectrum-tag-group-item-margin-inline));
.spectrum-TagGroup-actionButton {
justify-self: start;
}

.spectrum-TagGroup-helpText {
margin-block-start: var(--mod-tag-group-spacing-help-text-to-tags, var(--spectrum-tag-group-spacing-help-text-to-tags));
}

.spectrum-TagGroup--sideLabel {
grid-template-columns: auto auto;
grid-template-rows: auto auto auto;

.spectrum-TagGroup-label {
grid-row: 1;
grid-column: 1;
margin-block-end: 0;
margin-inline-end: var(--mod-tag-group-inline-spacing-label-to-tags, var(--spectrum-tag-group-inline-spacing-label-to-tags));
}

.spectrum-TagGroup-tags {
grid-row: 1;
grid-column: 2;
}

.spectrum-TagGroup-actionButton {
grid-row: 2;
grid-column: 2;
}

.spectrum-TagGroup-helpText {
grid-row: 3;
grid-column: 2;
}
}
Loading
Loading