Skip to content

feat(icon, ui-icons): add missing linkout icon #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rise-erpelding merged 3 commits into from
Jun 27, 2025
Merged

feat(icon, ui-icons): add missing linkout icon #3988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ebfc10
feat(ui-icons): add new icons
rise-erpelding Jun 24, 2025
a14565f
chore(ui-icons): manually remove unneeded icons
rise-erpelding Jun 26, 2025
9faff04
chore(icon): add icon class for linkout75
rise-erpelding Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cute-windows-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/ui-icons": minor
---

Updates ui-icons to include linkout-75 icon.
5 changes: 5 additions & 0 deletions .changeset/early-ends-fail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@spectrum-css/icon": minor
---

Adds icon class for link out 75 icon
4 changes: 3 additions & 1 deletion components/icon/dist/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@
".spectrum-UIIcon-LinkOut100",
".spectrum-UIIcon-LinkOut200",
".spectrum-UIIcon-LinkOut300",
".spectrum-UIIcon-LinkOut400"
".spectrum-UIIcon-LinkOut400",
".spectrum-UIIcon-LinkOut75"
],
"modifiers": [
"--mod-icon-block-size",
Expand Down Expand Up @@ -184,6 +185,7 @@
"--spectrum-link-out-icon-size-200",
"--spectrum-link-out-icon-size-300",
"--spectrum-link-out-icon-size-400",
"--spectrum-link-out-icon-size-75",
"--spectrum-workflow-icon-size-100",
"--spectrum-workflow-icon-size-200",
"--spectrum-workflow-icon-size-300",
Expand Down
4 changes: 4 additions & 0 deletions components/icon/ui-icons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,10 @@
}

/* Link out */
.spectrum-UIIcon-LinkOut75 {
--spectrum-icon-size: var(--spectrum-link-out-icon-size-75);
}

.spectrum-UIIcon-LinkOut100 {
--spectrum-icon-size: var(--spectrum-link-out-icon-size-100);
}
Expand Down
1 change: 1 addition & 0 deletions ui-icons/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ Iconography in v1 inclued 2 sizes, `medium` and `large`, as well as a single SVG
| SingleGripper | Deprecated |
| DoubleGripper | Deprecated |
| TripleGripper | Deprecated |
| LinkOut75 | **New** |
| LinkOut100 | **New** |
| LinkOut200 | **New** |
| LinkOut300 | **New** |
Expand Down
1 change: 1 addition & 0 deletions ui-icons/dist/icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"DragHandle200.svg",
"DragHandle300.svg",
"Gripper100.svg",
"LinkOut75.svg",
"LinkOut100.svg",
"LinkOut200.svg",
"LinkOut300.svg",
Expand Down
3 changes: 3 additions & 0 deletions ui-icons/dist/spectrum-css-icons.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions ui-icons/dist/svg/LinkOut75.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions ui-icons/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ async function copySVGs() {
function alphaNumericSort (a, b) {
const aSet = a.match(/^([a-z]+)([0-9]+)\.svg$/i);
const bSet = b.match(/^([a-z]+)([0-9]+)\.svg$/i);

// Handle files that don't match the pattern
if (!aSet || !bSet) {
return a.localeCompare(b); // Fallback to alphabetical sort
}

Comment on lines +100 to +105
Copy link
Copy Markdown
Collaborator Author

@rise-erpelding rise-erpelding Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the script was tripping and failing on MoveHorizontalTableWidget.svg because it has no size number, so adding this bit in to handle that.

I do see that this particular svg isn't new to 1.11.0 or 1.10.0, I believe it was present the last time that we updated icons to S2, so I've manually removed it as well as the other arrow icons that had previously been marked as deprecated, but I think it's still a good thing if our script works to handle svgs that don't have a size number attached.

Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say you removed it manually, do you mean that when you built the icons package, with the latest update, it was there with all the other UI icons? And that's when you removed it? This is just a question for my own understanding. 😊

I see this move-horizontal-table icon is in Figma (looks like it was added like 9 months ago). I wonder why we aren't keeping that icon in our CSS ui-icons set.

Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind- I found your comment on an individual commit. Sorry about that.

const aChar = aSet[1];
const bChar = bSet[1];

Expand Down
Loading