docs(progressbar): enable side label control#3992
Merged
castastrophe merged 1 commit intoJun 25, 2025
Merged
Conversation
|
Contributor
File metricsSummaryTotal size: 1.42 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
Contributor
📚 Branch previewPR #3992 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3992/index.html. |
ebb3585 to
89faba9
Compare
aramos-adobe
approved these changes
Jun 25, 2025
castastrophe
approved these changes
Jun 25, 2025
3 tasks
11 tasks
This was referenced Aug 27, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that the side label variant for progress bar was only surfaced in our Chromatic tests. Upon some closer inspection, we found a code comment that said we could turn on the side label control for S2 (Spectrum 1 didn't support side labels, according to our design docs).
This PR enables the
labelPositionStorybook control and adds a story to the docs page.NOTE: No changeset is needed since no CSS was changed (we already had CSS support for side labels- this PR just added a story to our docs and enabled the control officially for S2).
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
labelPositioncontrol is rendering in the control table.sideoption in thelabelPositiondropdown and verify the story changes as expected.progressbar.stories.js.Regression testing
Validate:
Screenshots
To-do list