Skip to content

chore: add manual testing guide to storybook#4015

Merged
castastrophe merged 1 commit into
spectrum-twofrom
castastrophe/docs-add-manual-testing-guide
Jul 10, 2025
Merged

chore: add manual testing guide to storybook#4015
castastrophe merged 1 commit into
spectrum-twofrom
castastrophe/docs-add-manual-testing-guide

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

Description

Because the process for running VRTs against the spectrum-two base branch differ from our automated system, this PR adds documentation to help developers through the process.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Follow the instructions listed here on a branch based against spectrum-two and highlight any gaps in the documentation.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 8, 2025

⚠️ No Changeset found

Latest commit: 5863acc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe self-assigned this Jul 8, 2025
@castastrophe castastrophe added documentation Because documentation is important and shouldn't be broken size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. ready-for-review S2 Spectrum 2 labels Jul 8, 2025
@castastrophe castastrophe requested a review from a team July 8, 2025 15:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

File metrics

Summary

Total size: 1.43 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

📚 Branch preview

PR #4015 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4015/index.html.

Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions for you 😊


### Configure Chromatic access

Run `yarn refresh` to create or update your `.env` file with the necessary environment variables. Ensure the `CHROMATIC_PROJECT_TOKEN` is set correctly.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it helpful at all to note that the chromatic.config.json in the storybook directory should also have the chromatic project token?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could add that though that file is created by the yarn refresh script so updating it manually will get blown away once you refresh.

Comment on lines +39 to +45
### Basic test execution

Because the base branch is not `main`, VRT builds are kicked off locally. This makes the build available in the Chromatic UI in order to create a manual review. To get an up-to-date comparison of your branch against the base branch, run the following command on the branch you are testing.

```bash
yarn test
```
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running into issues with yarn test and getting a few errors. I'd gotten one about failing to build the preview, and then another with "can't evaluate main.js," so the test command was either hanging, or was just exit. I ended up running yarn nx reset, and poof- yarn test worked! Is it worth mentioned that at all, like sometimes the Nx cache need to be cleared or something?

This also could have just been me, and/or common knowledge that I missed 🤣

@castastrophe castastrophe force-pushed the castastrophe/docs-add-manual-testing-guide branch from 1ebe503 to 5863acc Compare July 10, 2025 16:26
@castastrophe castastrophe merged commit f836f90 into spectrum-two Jul 10, 2025
13 checks passed
@castastrophe castastrophe deleted the castastrophe/docs-add-manual-testing-guide branch July 10, 2025 17:44
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Because documentation is important and shouldn't be broken ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants