Skip to content

fix(lint-staged): remove conflicting flag for prettier command#4038

Merged
cdransf merged 1 commit into
spectrum-twofrom
cdransf/lint-staged-prettier-fix
Jul 15, 2025
Merged

fix(lint-staged): remove conflicting flag for prettier command#4038
cdransf merged 1 commit into
spectrum-twofrom
cdransf/lint-staged-prettier-fix

Conversation

@cdransf
Copy link
Copy Markdown
Member

@cdransf cdransf commented Jul 15, 2025

Description

This fixes the prettier portion of our lint stage hooked by removing the --no-config flag that conflicts with the final --config .prettierrc flag.

How and where has this been tested?

Verified by removing the flag in question and running a test commit.

Validation steps

  1. Pull down the branch.
  2. Install project dependencies using yarn.
  3. Make a small change to a *.css file.
  4. Commit the file to verify the lint-staged hook runs successfully.
  5. Reset your branch. Do not push the change.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf self-assigned this Jul 15, 2025
@cdransf cdransf added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Jul 15, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: 5a72ac2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@spectrum-css/ui-icons Minor
@spectrum-css/icon Minor
@spectrum-css/popover Minor
@spectrum-css/preview Patch
@spectrum-css/bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf changed the base branch from main to spectrum-two July 15, 2025 17:51
@cdransf cdransf enabled auto-merge (squash) July 15, 2025 20:06
@github-actions
Copy link
Copy Markdown
Contributor

📚 Branch preview

PR #4038 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4038/index.html.

@github-actions
Copy link
Copy Markdown
Contributor

File metrics

Summary

Total size: 1.43 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@cdransf cdransf merged commit 9dd71ed into spectrum-two Jul 15, 2025
15 checks passed
@cdransf cdransf deleted the cdransf/lint-staged-prettier-fix branch July 15, 2025 20:24
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants