Skip to content

feat(menu): S2 menu fast follows#4058

Merged
5t3ph merged 13 commits into
spectrum-twofrom
seckles/css-1216-menu-fast-follow
Jul 31, 2025
Merged

feat(menu): S2 menu fast follows#4058
5t3ph merged 13 commits into
spectrum-twofrom
seckles/css-1216-menu-fast-follow

Conversation

@5t3ph
Copy link
Copy Markdown
Contributor

@5t3ph 5t3ph commented Jul 24, 2025

Description

This handles a few remaining items from the initial S2 migration:

  • update to use the correct "LinkOut" icon (previously unavailable)
  • add "Unavailable" icon
    • the functionality in WC will be to open an explanatory popover

Additionally, per design review, updates were made for tests and stories regarding valid feature combos:

  • Not allowed:
    • external links with: thumbnails, drill-in, unavailable, or selection modes
    • thumbnails with: drill-in, external links
    • new "unavailable" with: selection modes, external links
  • Updates:
    • added "With description" to complete feature testing for selection modes

Still pending for this component (non-blocking for this PR):

  • possibly thumbnail token updates, which will split to be handled separately if so

Validation steps

Review the Menu stories and check:

  • "LinkOut" icon is used for the "External link" option (@cdransf)
  • "InfoCircle" icon is used for the "Unavailable" option (@cdransf)
  • stories are complete for new/updated options (@cdransf)
  • tests are complete for new/updated options (@cdransf)

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.

Screenshots

image image

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • Design has reviewed and validated menu item combinations.
  • ✨ This pull request is ready to merge. ✨

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 24, 2025

🦋 Changeset detected

Latest commit: a5fcd4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@spectrum-css/menu Minor
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread components/menu/index.css
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2025

File metrics

Summary

Total size: 1.44 MB*

Package Size Minified Gzipped
menu 48.04 KB 45.78 KB 5.10 KB

menu

Filename Head Minified Gzipped Compared to base
index.css 48.04 KB 45.78 KB 5.10 KB 🟢 ⬇ 0.24 KB
metadata.json 23.93 KB - - 🔴 ⬆ 0.19 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 24, 2025

📚 Branch preview

PR #4058 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4058/index.html.

Copy link
Copy Markdown
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just had one non-blocking question. ✨

Comment thread components/menu/stories/menu.test.js
Copy link
Copy Markdown
Collaborator

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some comments, this looks really nice overall and I'm not sure there are necessarily any changes that need to be requested, but I did have a lot of questions/callouts that may or may not need addressing and wasn't sure I was ready to approve because of them.

Comment thread .changeset/small-berries-dream.md
Comment thread components/menu/index.css
Comment thread components/menu/stories/menu.stories.js Outdated
Comment thread components/menu/index.css
Comment thread components/menu/stories/menu.test.js
Comment thread .changeset/small-berries-dream.md
Comment thread components/tabs/index.css
@5t3ph
Copy link
Copy Markdown
Contributor Author

5t3ph commented Jul 30, 2025

But would drill-ins exist in a selection mode? 🤔

Checking on this with design

@rise-erpelding rise-erpelding self-requested a review July 31, 2025 17:20
@5t3ph 5t3ph merged commit d831bd0 into spectrum-two Jul 31, 2025
13 checks passed
@5t3ph 5t3ph deleted the seckles/css-1216-menu-fast-follow branch July 31, 2025 18:16
@github-actions github-actions Bot mentioned this pull request Jul 31, 2025
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants