feat(menu): S2 menu fast follows#4058
Conversation
🦋 Changeset detectedLatest commit: a5fcd4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 1.44 MB*
menu
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
📚 Branch previewPR #4058 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4058/index.html. |
…into seckles/css-1216-menu-fast-follow
cdransf
left a comment
There was a problem hiding this comment.
This looks great! Just had one non-blocking question. ✨
rise-erpelding
left a comment
There was a problem hiding this comment.
Leaving some comments, this looks really nice overall and I'm not sure there are necessarily any changes that need to be requested, but I did have a lot of questions/callouts that may or may not need addressing and wasn't sure I was ready to approve because of them.
…into seckles/css-1216-menu-fast-follow
Checking on this with design |
…into seckles/css-1216-menu-fast-follow
Description
This handles a few remaining items from the initial S2 migration:
Additionally, per design review, updates were made for tests and stories regarding valid feature combos:
Still pending for this component (non-blocking for this PR):
Validation steps
Review the Menu stories and check:
Regression testing
Validate:
Screenshots
To-do list