fix(search): remove duplicate isdisabled arg#4136
Conversation
|
File metricsSummaryTotal size: 1.43 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
📚 Branch previewPR #4136 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4136/index.html. |
| ActionButton({ | ||
| iconName: "Search", | ||
| isDisabled, | ||
| isHovered, |
There was a problem hiding this comment.
Because action button has an isHovered arg too, I figured it was ok to move the isHovered arg from customClasses up here.
0dd1ab7 to
9a2a6b1
Compare
9a2a6b1 to
c7286bd
Compare
| isHovered && "is-hover", | ||
| isDisabled && "is-disabled", |

Description
I noticed there were accidentally 2
isDisabledarguments passed to the action button subcomponent found within the collapsed search field.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
search/stories/template.jsfile, verify there is only oneisDisabledargument passed to the nestedActionButton.isDisabled && "is-disabled"has been removed from the customClasses object, in favor of passingisDisableda single time to action button.Additional validation
isCollapsedandisDisabledargs totrue.TABkey, attempt to focus on the collapsed search field's action button.Regression testing
Validate:
Screenshots
To-do list