Skip to content

fix(search): remove duplicate isdisabled arg#4136

Merged
marissahuysentruyt merged 1 commit into
spectrum-twofrom
marissahuysentruyt/fix-search-duplicate-isdisabled-arg
Aug 20, 2025
Merged

fix(search): remove duplicate isdisabled arg#4136
marissahuysentruyt merged 1 commit into
spectrum-twofrom
marissahuysentruyt/fix-search-duplicate-isdisabled-arg

Conversation

@marissahuysentruyt
Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt commented Aug 18, 2025

Description

I noticed there were accidentally 2 isDisabled arguments passed to the action button subcomponent found within the collapsed search field.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Pull down the branch to run locally or visit the deploy preview.
  • In the search/stories/template.js file, verify there is only one isDisabled argument passed to the nested ActionButton.
    • The line isDisabled && "is-disabled" has been removed from the customClasses object, in favor of passing isDisabled a single time to action button.

Additional validation

  • Navigate to the default search field story page and toggle the isCollapsed and isDisabled args to true.
  • With the TAB key, attempt to focus on the collapsed search field's action button.
  • Verify that the blue focus indicator is not visible.
  • Verify no visual regressions have been introduced.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • ✨ This pull request is ready to merge. ✨

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 18, 2025

⚠️ No Changeset found

Latest commit: c7286bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marissahuysentruyt marissahuysentruyt changed the base branch from main to spectrum-two August 18, 2025 14:10
@marissahuysentruyt marissahuysentruyt changed the title Marissahuysentruyt/fix search duplicate isdisabled arg fix(search): remove duplicate isdisabled arg Aug 18, 2025
@marissahuysentruyt marissahuysentruyt self-assigned this Aug 18, 2025
@marissahuysentruyt marissahuysentruyt added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. S2 Spectrum 2 bug Results from a bug in the CSS implementation labels Aug 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 18, 2025

File metrics

Summary

Total size: 1.43 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 18, 2025

📚 Branch preview

PR #4136 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4136/index.html.

ActionButton({
iconName: "Search",
isDisabled,
isHovered,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because action button has an isHovered arg too, I figured it was ok to move the isHovered arg from customClasses up here.

@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/fix-search-duplicate-isdisabled-arg branch from 0dd1ab7 to 9a2a6b1 Compare August 18, 2025 14:48
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/fix-search-duplicate-isdisabled-arg branch from 9a2a6b1 to c7286bd Compare August 20, 2025 15:10
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review August 20, 2025 15:11
@marissahuysentruyt marissahuysentruyt removed the bug Results from a bug in the CSS implementation label Aug 20, 2025
Comment on lines -49 to -50
isHovered && "is-hover",
isDisabled && "is-disabled",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were evaluating to "false" previously:
Screenshot 2025-08-20 at 10 55 29 AM

@marissahuysentruyt marissahuysentruyt merged commit 9809b47 into spectrum-two Aug 20, 2025
19 of 26 checks passed
@marissahuysentruyt marissahuysentruyt deleted the marissahuysentruyt/fix-search-duplicate-isdisabled-arg branch August 20, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants