Skip to content

Fix brevo transport, API allows onyl one replyTo address, not an array #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thetutlage merged 1 commit into from
Mar 20, 2025
Merged

Fix brevo transport, API allows onyl one replyTo address, not an array #106

thetutlage merged 1 commit into from
Mar 20, 2025

Conversation

@arthur-pigeon
Copy link
Contributor

@arthur-pigeon arthur-pigeon commented Mar 19, 2025

🔗 Linked issue

#105

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Brevo allow only one replyTo address as a object not a array object

Not valid:

curl -X POST "https://api.brevo.com/v3/smtp/email" \
-H "accept: application/json" \
-H "api-key: xkeysib-dunno" \
-H "Content-Type: application/json" \
-d '{
  "sender": {
    "name": "Sender Name",
    "email": "no-reply@yes.com"
  },
  "to": [
    {
      "email": "test@test.com",
      "name": "Recipient Name"
    }
  ],
  "replyTo": [{
    "email": "reply-me@yes.com",
    "name": "Reply To Name"
  }],
  "subject": "Your Subject Here",
  "htmlContent": "<html><body><p>Your email content here.</p></body></html>"
}'

Error: {"code":"invalid_parameter","message":"replyTo is not valid"}

If you don't pass a array but an object directly it works perfectly

❓ Type of change
 🐞 Bug fix (a non-breaking change that fixes an issue)
 👌 Enhancement (improving an existing functionality like performance)
 ✨ New feature (a non-breaking change that adds functionality)
 ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
📚 Description
Brevo allow only one replyTo address as a object not a array object

Not valid:

curl -X POST "https://api.brevo.com/v3/smtp/email" \
-H "accept: application/json" \
-H "api-key: xkeysib-dunno" \
-H "Content-Type: application/json" \
-d '{
  "sender": {
    "name": "Sender Name",
    "email": "no-reply@yes.com"
  },
  "to": [
    {
      "email": "test@test.com",
      "name": "Recipient Name"
    }
  ],
  "replyTo": [{
    "email": "reply-me@yes.com",
    "name": "Reply To Name"
  }],
  "subject": "Your Subject Here",
  "htmlContent": "<html><body><p>Your email content here.</p></body></html>"
}'
Error: {"code":"invalid_parameter","message":"replyTo is not valid"}

If you don't pass a array but an object directly it works perfectly

curl -X POST "https://api.brevo.com/v3/smtp/email" \
-H "accept: application/json" \
-H "api-key: xkeysib-dunno" \
-H "Content-Type: application/json" \
-d '{
  "sender": {
    "name": "Sender Name",
    "email": "no-reply@yes.com"
  },
  "to": [
    {
      "email": "test@test.com",
      "name": "Recipient Name"
    }
  ],
  "replyTo": {
    "email": "reply-me@yes.com",
    "name": "Reply To Name"
  },
  "subject": "Your Subject Here",
  "htmlContent": "<html><body><p>Your email content here.</p></body></html>"
}'

This is the exact same PR (almost) as #104

Brevo documentation here

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@arthur-pigeon
Copy link
Contributor Author

arthur-pigeon commented Mar 19, 2025

If approved, when would this be upstreamed ?

@thetutlage
Copy link
Member

thetutlage commented Mar 20, 2025

Looks good to me!

@thetutlage thetutlage merged commit 99b1695 into adonisjs:develop Mar 20, 2025
1 of 4 checks passed
@thetutlage thetutlage mentioned this pull request Mar 20, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arthur-pigeon @thetutlage