Skip to content
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

Update and structure validator API#40

Closed
bitkidd wants to merge 2 commits intoadonisjs:developfrom
bitkidd:develop
Closed

Update and structure validator API#40
bitkidd wants to merge 2 commits intoadonisjs:developfrom
bitkidd:develop

Conversation

@bitkidd
Copy link
Copy Markdown

@bitkidd bitkidd commented Jun 17, 2021

This proposal suggests to clean up the api by splitting the roles of methods, removing options from schemes and grouping them into corresponding groups: rules or a new group - modifiers, that takes the role of value mutation.

Full Rendered Proposal
Discussion Thread

@thetutlage
Copy link
Copy Markdown
Member

@targos @RomainLanz What you guys think?

@targos
Copy link
Copy Markdown
Member

targos commented Jun 21, 2021

I'm generally ok with the approach.
I'd still like us to find a way to help the user select the right rules (so they have an error when adding a string rule or modifier to a number field, or even better if we can prevent intellisense from suggesting wrong ones)

@bitkidd bitkidd closed this by deleting the head repository Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants