macos ansible setup improvements#3410
Conversation
This PR is amed to add Xcode_offline which installs xcode without need to use any other 3rd party resource. Also some minor code changes and improvement added (e.g. install brew)
sxa
left a comment
There was a problem hiding this comment.
I've added a couple of other people as reviewers who are more knowledgeable about the macos stuff than I am but from a general perspective:
- At present we use the
main.ymlfile for macos, so switching to use a separate one superficially feels like a slightly backwards step. Is it possible to integrate some of these changes into the normal execution ofmain.ymlor is there a reason why you have chosen to do this as a separate top level file? - This seems to have quite significant changes to some of the roles such as the ant-contrib one - are they specific to the goal of this PR to improve usability of the macos playbooks?
- Similarly this seems to change how things like the credentials are retrieved for the Jenkins_User role, which would be a change in behaviour.
Perhaps some of those things can be decoupled from this PR and proposed separately unless there is a reason they've all been put together.
|
|
@mahdipub Can you resolve the linter fixes? |
|
Based on comments on slack, I will close this PR and split changes in 2~3 PRs. The one related to Xcode-offline and the other for brew is #3417. |
unixPB: This PR is amed to add Xcode_offline which installs xcode without need to use any other 3rd party resource. Also some minor code changes and improvement added (e.g. install brew)
Checklist