Skip to content

WindowsPB: Add Incredibuild Dashboard Configuration Task#3726

Merged
steelhead31 merged 4 commits into
adoptium:masterfrom
steelhead31:fix_aqa_5474
Sep 9, 2024
Merged

WindowsPB: Add Incredibuild Dashboard Configuration Task#3726
steelhead31 merged 4 commits into
adoptium:masterfrom
steelhead31:fix_aqa_5474

Conversation

@steelhead31
Copy link
Copy Markdown
Contributor

@steelhead31 steelhead31 commented Sep 4, 2024

Fixes: adoptium/aqa-tests#5474

As seen in the above issue, the jwebserver tests fail due to a conflict with a process on port 8000. After investigation, this turns out to be a clash with the incredibuild dashboard service.

This change, reconfigures the Incredibuild dashboard service to use a different port. ( The incredibuild service uses port 30000, so 31000 seemed appropriate for the dashboard. Also having carried out investigation, I cannot find any other services using this port on Windows.

Checklist

VPC Completed OK : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/1959/console

@steelhead31 steelhead31 marked this pull request as draft September 4, 2024 11:16
@steelhead31 steelhead31 marked this pull request as ready for review September 5, 2024 15:29
Copy link
Copy Markdown
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add to Adoptium project, story points, etc...

Comment thread ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/Incredibuild/tasks/main.yml Outdated
Copy link
Copy Markdown
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, but do we even need the incredibuild service running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JDK22 & JDK21: CommandLinePositiveTest.java (httpserver and jwebserver versions) both fail with address in use

4 participants