WinPB: Add Installation of VS2022 Redists#3774
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
karianna
left a comment
karianna
left a comment
There was a problem hiding this comment.
Can we extract the version # to a const at the top and reference that?
@karianna , I can envisage a situation whereby we might install multiple different Windows SDK versions for later JDKs. although this might be redundant when we move over to full windows devkit style builds... I'll make this change for now, and re-evaluate should the need arise. |
andrew-m-leonard
left a comment
andrew-m-leonard
left a comment
There was a problem hiding this comment.
looks good thanks
Co-Authored-By: Stewart X Addison <6487691+sxa@users.noreply.github.com>
steelhead31
force-pushed
the
fix_issue_3772
branch
from
c03f9f0 to
6345cb9
Compare
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
|
/approve |
1 similar comment
|
/approve |
github-actions
Bot
dismissed
their stale review
Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
4 participants
Fixes #3772
Required as part of https://github.com/adoptium/temurin-build/pull/3981/files
Checklist
VPC Successful : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/1982/console