Skip to content

ansible: Updated used wix version to 5.0.2#3899

Merged
steelhead31 merged 1 commit into
adoptium:masterfrom
jmjaffe37:jmj/wix_update
Mar 6, 2025
Merged

ansible: Updated used wix version to 5.0.2#3899
steelhead31 merged 1 commit into
adoptium:masterfrom
jmjaffe37:jmj/wix_update

Conversation

@jmjaffe37
Copy link
Copy Markdown
Contributor

@jmjaffe37 jmjaffe37 commented Mar 5, 2025

Updated used wix version to 5.0.2

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@jmjaffe37 jmjaffe37 changed the title Updated used wix version to 5.0.2 ansible: Updated used wix version to 5.0.2 Mar 5, 2025
@jmjaffe37
Copy link
Copy Markdown
Contributor Author

Raised at the suggestion of @gdams to go along with my other PR to update the default wix version that adoptium uses.
CC: @karianna

@karianna karianna requested a review from gdams March 5, 2025 20:32
@gdams
Copy link
Copy Markdown
Member

gdams commented Mar 6, 2025

LGTM @steelhead31 are you able to run this update on the windows machines?

@steelhead31
Copy link
Copy Markdown
Contributor

@gdams I can, ( it will likely happen automatically with the weekly playbook deployment anyway ), but that said, I think we'll need an update to the docker image used for the windows builds now, as I think all of the windows builds are done via docker.. @sxa is my assumption correct ?

@sxa
Copy link
Copy Markdown
Member

sxa commented Mar 6, 2025

@gdams I can, ( it will likely happen automatically with the weekly playbook deployment anyway ), but that said, I think we'll need an update to the docker image used for the windows builds now, as I think all of the windows builds are done via docker.. @sxa is my assumption correct ?

Correct - the automated windows container updating is awaiting #3780

However the installer creation is NOT done in a container, so this will just need to be deployed to the rest of the machines. The weekly runs will likely not automatically deploy if it finds an existing 5.0.0 in the machine since it's just checking for the presence of C:\\Program Files\dotnet\wix.exe` before deciding whether to install so this would need to be manually applied to the relevant machines.

@steelhead31
Copy link
Copy Markdown
Contributor

Thanks @sxa, in that case, I'll merge and deploy this to the windows hosts this afternoon, if that'sok @gdams ?

@gdams
Copy link
Copy Markdown
Member

gdams commented Mar 6, 2025

Thanks @sxa, in that case, I'll merge and deploy this to the windows hosts this afternoon, if that'sok @gdams ?

sounds good to me

@steelhead31 steelhead31 merged commit 333db0d into adoptium:master Mar 6, 2025
@steelhead31
Copy link
Copy Markdown
Contributor

Wix has been updated on the one machine used for building windows installers ( build-azure-win2022-x64-1 )

@jmjaffe37 jmjaffe37 deleted the jmj/wix_update branch March 6, 2025 19:46
@jmjaffe37
Copy link
Copy Markdown
Contributor Author

Thanks for the support team! Now I just have the related PR in the adoptium/installer repo remaining: adoptium/installer#1136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants