fix: address #49 #50 #46 (embed race, LLM signature, Node 24 compat)#54
Open
zhuanxqq wants to merge 1 commit intoadoresever:mainfrom
Open
fix: address #49 #50 #46 (embed race, LLM signature, Node 24 compat)#54zhuanxqq wants to merge 1 commit intoadoresever:mainfrom
zhuanxqq wants to merge 1 commit intoadoresever:mainfrom
Conversation
…esever#46, adoresever#44-related) - fix(llm): support LlmConfig object as first arg in createCompleteFn so direct-maintain.ts works without signature mismatch (adoresever#49) - fix(recaller): add embedReady promise to eliminate race condition between createEmbedFn and recall(), ensuring embedFn is always awaited before vector search (adoresever#50) - fix(build): migrate to NodeNext ESM + .js extensions for Node.js v24 compatibility, output dist/ and point package main there (adoresever#46) - chore(ports): searched codebase; no hardcoded 18787/18789 found, port mismatch lives outside this repo (adoresever#44) Tests: 80 passed. Build: dist/ generated successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several open issues:
Verification:
RUN v1.6.1 /Users/hl/work/graph-memory
✓ test/extract.test.ts (22 tests) 6ms
✓ test/assemble.test.ts (11 tests) 12ms
✓ test/recall-community.test.ts (13 tests) 13ms
✓ test/store.test.ts (17 tests) 19ms
✓ test/graph.test.ts (17 tests) 15ms
Test Files 5 passed (5)
Tests 80 passed (80)
Start at 20:23:00
Duration 344ms (transform 279ms, setup 0ms, collect 464ms, tests 65ms, environment 0ms, prepare 317ms): 80/80 passed