Fix(calendar): all-day events in iCalendar format (RFC 5545)

[Marc-Andrieu]

Description

Summary

Now, day(s)-long events are also displayed as such, on the event module's calendar, on Google Calendar and on iOS iCalendar, AND the start and end dates are correct.

Sources

RFC 5545, 3.6.1. Event Component:

The "DTSTART" property for a "VEVENT" specifies the inclusive start of the event. For recurring events, it also specifies the very first instance in the recurrence set. The "DTEND" property for a "VEVENT" calendar component specifies the non-inclusive end of the event. For cases where a "VEVENT" calendar component specifies a "DTSTART" property with a DATE value type but no "DTEND" nor "DURATION" property, the event's duration is taken to be one day.

Issues/PR dependencies

Issues to be resolved

Fixes #331

Changes Made

• All-day events are recognized as such on the 3 calendars clients. That was pretty easy
• There is no gap, shift in days, missing days or extra days. That was not so easy, I had to find the explication in the RFC to be sure of what they did.
• Classical events are still OK.
• Resilient to daylight saving time: no matter if your event is scheduled in November or in May, the 3 calendars display the same thing.

Classification

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
• 🔧 Infra CI/CD (changes to configs of workflows)
• 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
• 😶‍🌫️ No impact for the end-users

Impact & Scope

• Core functionality changes
• Single module changes
• Multiple modules changes
• Database migrations required
• Other: ...

Testing

• 1. Tested this locally,
  • and importing in my Google Calendar,
  • and asked a iPhone friend to import my local file in iCalendar
• 2. Added/modified tests that pass the CI (or tested in a downstream fork)
• 3. Tested in a deployed pre-prod
• 0. Untestable (exceptionally), will be tested in prod directly

Documentation

• Updated the docs accordingly :
• " Docstrings
• # Inline comments
• No documentation needed

[Marc-Andrieu]

Also fixed the typo: the name is PRODID (Product Identifier) not PROID, and the value should be RFC 5545 compliant (section 4.7.3)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.19%. Comparing base (a683ea8) to head (2c87993).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #906       +/-   ##
===========================================
- Coverage   85.91%   50.19%   -35.72%     
===========================================
  Files         193      193               
  Lines       14967    14969        +2     
===========================================
- Hits        12859     7514     -5345     
- Misses       2108     7455     +5347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.