Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
===========================================
- Coverage 85.89% 55.67% -30.22%
===========================================
Files 193 193
Lines 14954 14967 +13
===========================================
- Hits 12844 8333 -4511
- Misses 2110 6634 +4524 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
warix8
approved these changes
Nov 29, 2025
Rotheem
approved these changes
Nov 29, 2025
Rotheem
pushed a commit
that referenced
this pull request
Dec 19, 2025
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> ... <!--#### Sources at the end--> ## Issues/PR dependencies <!--Use a keyword, then #123 for the same repo or aeecleclair/RepoName#123 for another--> ### Issues to be resolved <!--Keywords: "closes", "fixes", "resolves" --> <!--Fixes #--> ### Required PRs <!--Keywords: "depends on", "blocked by" --> <!--Depends on #--> ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] ... - [ ] ... ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [ ] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [x] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [ ] Other: ... <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [ ] No documentation needed </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
...
Issues/PR dependencies
Issues to be resolved
Required PRs
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments