Skip to content

Fix(sport_competition): remove unconditional & lengthy logs#956

Closed
Marc-Andrieu wants to merge 1 commit intomainfrom
fix/sport_competition/unconditional-logs
Closed

Fix(sport_competition): remove unconditional & lengthy logs#956
Marc-Andrieu wants to merge 1 commit intomainfrom
fix/sport_competition/unconditional-logs

Conversation

@Marc-Andrieu
Copy link
Member

Description

Summary

These logs:

  • are unconditional: always happen, and that's a GET request
  • so we're gonna be spammed we are being spammed in the logs
  • they leak personal user data in the logs
  • Remove these logs

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

@Marc-Andrieu Marc-Andrieu self-assigned this Feb 15, 2026
@Marc-Andrieu Marc-Andrieu added logging ready for review This PR is ready to be reviewed fix bug This PR fix a bug code quality labels Feb 15, 2026
@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.35%. Comparing base (fc596b7) to head (8e07af8).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #956       +/-   ##
===========================================
- Coverage   84.83%   55.35%   -29.49%     
===========================================
  Files         205      205               
  Lines       14637    14634        -3     
===========================================
- Hits        12417     8100     -4317     
- Misses       2220     6534     +4314     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rotheem
Copy link
Member

Rotheem commented Feb 15, 2026

Useless as it is already removed in #955

@Rotheem Rotheem closed this Feb 15, 2026
@Marc-Andrieu Marc-Andrieu deleted the fix/sport_competition/unconditional-logs branch March 1, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality fix bug This PR fix a bug logging ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants