Skip to content

Fix memberships factory#969

Merged
barimuls merged 1 commit intomainfrom
fix/memberships_factory
Feb 28, 2026
Merged

Fix memberships factory#969
barimuls merged 1 commit intomainfrom
fix/memberships_factory

Conversation

@warix8
Copy link
Contributor

@warix8 warix8 commented Feb 28, 2026

Description

Summary

The memberships factory was not run because memberships had already been declared by other factories.

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • [] Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: Small factory fix

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@warix8 warix8 added bug Something isn't working good first issue Good for newcomers ready for review This PR is ready to be reviewed labels Feb 28, 2026
@warix8 warix8 requested a review from Marc-Andrieu February 28, 2026 11:39
@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (6e7647b) to head (f9406dc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
+ Coverage   84.39%   84.44%   +0.05%     
==========================================
  Files         205      205              
  Lines       14816    14821       +5     
==========================================
+ Hits        12504    12516      +12     
+ Misses       2312     2305       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NakoGH NakoGH force-pushed the fix/memberships_factory branch from dfa5d7b to f9406dc Compare February 28, 2026 16:22
Copy link

@barimuls barimuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@barimuls barimuls merged commit 09ded1e into main Feb 28, 2026
7 checks passed
@barimuls barimuls deleted the fix/memberships_factory branch February 28, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants