Skip to content

Fix: change MINIMAL_TITAN_VERSION_CODE type to int#970

Merged
Rausterr merged 1 commit intomainfrom
fix-type-titan-code
Feb 28, 2026
Merged

Fix: change MINIMAL_TITAN_VERSION_CODE type to int#970
Rausterr merged 1 commit intomainfrom
fix-type-titan-code

Conversation

@Khl0r0
Copy link
Contributor

@Khl0r0 Khl0r0 commented Feb 28, 2026

Description

Summary

MINIMAL_TITAN_VERSION_CODE was a string instead of an integer as required by /information endpoint.

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • Replaced str cast by int cast in Settings

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (09ded1e) to head (65ad590).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #970   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         205      205           
  Lines       14821    14821           
=======================================
  Hits        12516    12516           
  Misses       2305     2305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Rausterr Rausterr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Rausterr Rausterr force-pushed the fix-type-titan-code branch from 14bad6e to 65ad590 Compare February 28, 2026 20:37
@Rausterr Rausterr merged commit c5cb7ee into main Feb 28, 2026
7 checks passed
@Rausterr Rausterr deleted the fix-type-titan-code branch February 28, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants