Skip to content

Competition validation and cancel fixes#977

Merged
Rotheem merged 2 commits intomainfrom
competition-validation-and-cancel
Mar 11, 2026
Merged

Competition validation and cancel fixes#977
Rotheem merged 2 commits intomainfrom
competition-validation-and-cancel

Conversation

@Rotheem
Copy link
Member

@Rotheem Rotheem commented Mar 11, 2026

Description

Summary

Allows volunteer validation and auto validate free products
Fix participation cancelling

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.42%. Comparing base (acba6e2) to head (e69cfb7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/sport_competition/endpoints_sport_competition.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   84.44%   84.42%   -0.02%     
==========================================
  Files         205      205              
  Lines       14873    14881       +8     
==========================================
+ Hits        12560    12564       +4     
- Misses       2313     2317       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rotheem Rotheem merged commit 4282ad5 into main Mar 11, 2026
7 checks passed
@Rotheem Rotheem deleted the competition-validation-and-cancel branch March 11, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants