fix: prevent --rebuild from instantly terminating on stale page limits#95
Draft
ccage-simp wants to merge 1 commit intoafar1:mainfrom
Draft
fix: prevent --rebuild from instantly terminating on stale page limits#95ccage-simp wants to merge 1 commit intoafar1:mainfrom
ccage-simp wants to merge 1 commit intoafar1:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
ft sync --rebuildterminates instantly on first page if bookmarks already existDescribe the bug
When running
ft sync --rebuildon an existing cache, the sync process instantly terminates with "caught up tonewest stored bookmark". The
--rebuildflag is supposed to crawl the entire timeline, but because no newbookmarks are added on the first page, the
stalePagescounter triggers and halts the loop.To Reproduce
ft sync --rebuild.Expected behavior
In
--rebuildmode, the sync should only be considered "stale" if the API returns 0 total records on a page, not 0new records.
Suggested Fix
In
src/graphql-bookmarks.ts, update thestalePagescounter logic to differentiate between incremental andrebuild mode: