Included condition to allow @ character on console Input#15
Included condition to allow @ character on console Input#15c3sxr wants to merge 5 commits intoafucher:devfrom
Conversation
afucher
left a comment
afucher
left a comment
There was a problem hiding this comment.
Thanks for your PR!
I added some suggestion about the fix, and also it will be good to add a test to replicate this error. If you need any help with this, please let me know.
…ed validation on ConsoleObservable:ImplementKeysBehaviours and in ConsoleObservable:GetLineObservable to allow @ character
|
hey @c3sxr , could you please add some tests for this bug? |
|
Hi @afucher ! |
|
Hey @c3sxr for some reason it is not reflecting any new changes here in the Pull Request 😕 |
|
Can you please look again, the File changes tab is showing my new changes |
|
Oh those files I saw, my comment was regarding adding a new test that cover the @ bug |
|
Oh you mean on the InquirerUnitTest? Sure let me include it |
|
Can you please take a look and let me know if that looks right? |
| case 'ü': | ||
| return new ConsoleKeyInfo('ü', ConsoleKey.U, false, false, false); | ||
| case '@': | ||
| return new ConsoleKeyInfo('@', ConsoleKey.D2, false, false, false); |
There was a problem hiding this comment.
I think the first boolean parameter represent the shift key, and in this case it should be true. Could you check please?
There was a problem hiding this comment.
You're right the parameter shift needed to be true. Can you please review again?
Thanks!
3 participants
If the digit is D2 (@ special character) then it will go back one character and the next will replace it
I included a condition to avoid this and include the @ special character as an input character