Fix 2 pre-existing test failures in test_tools.py#49
Merged
Conversation
- Remove assertion for internal ID "tx-1" in test_transaction_history_success since the transaction tool intentionally omits IDs from its Markdown output - Fix test_risk_assessment_success mock: change EUR Exposure to isActive=True with value=False so it generates a WARN status alongside the PASS Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflict in test_risk_assessment_success: keep xRay.categories format from main (NAS-231) instead of old rules format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tx-1intest_transaction_history_success— the transaction tool intentionally omits internal IDs from its Markdown table outputtest_risk_assessment_successmock data: changedEUR ExposurefromisActive: FalsetoisActive: True, value: Falseso it generates a WARN status, matching the test's assertion for both PASS and WARNTest plan
test_tools.pypass (0 failures)🤖 Generated with Claude Code