fix: key chat history by stable user ID instead of JWT token#61
Merged
Conversation
Ghostfolio issues a new JWT on every login (including browser refresh), so keying chat history by SHA256(token) caused users to lose their conversation on refresh. Now we decode the JWT payload to extract the stable `id` field and key by SHA256(user_id) instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Tests passing. Checked for bugs, regressions, and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHA256(jwt_token), but Ghostfolio issues a new JWT on every login/refresh, causing users to lose their conversationidfield and keys bySHA256(user_id)instead/chat,/chat/historyGET, and/chat/historyDELETE endpoints inmain.pyTest plan
session_idoverride still works (non-JWT strings fall back gracefully)🤖 Generated with Claude Code