sync: vendor glide-mq skills from upstream avifenesh/glide-mq@v0.15.1#1
Merged
sync: vendor glide-mq skills from upstream avifenesh/glide-mq@v0.15.1#1
Conversation
Upstream skills had advanced significantly (v0.14.0 / v0.15.1) while our vendored copies were stuck at thin-wrapper v1.0.0. Replacing all three SKILL.md files plus their references/ subdirectories with the upstream content at SHA ae9c0fa6. Added: - LICENSE (Apache-2.0, copied from upstream) - skills/UPSTREAM.md tracker recording upstream URL, SHA, version, sync date - scripts/sync-upstream.sh for re-syncing to a chosen ref - scripts/check-upstream-drift.sh for drift detection - .github/workflows/check-upstream-drift.yml weekly CI cron that opens an issue when our recorded SHA falls behind upstream HEAD Files synced from upstream: - skills/glide-mq/SKILL.md + 10 references (ai-native, broadcast, connection, observability, queue, schedulers, search, serverless, worker, workflows) - skills/glide-mq-migrate-bullmq/SKILL.md + 2 references (connection-mapping, new-features) - skills/glide-mq-migrate-bee/SKILL.md + 2 references (api-mapping, new-features) Workflow going forward: edits to these SKILL.md files happen upstream at avifenesh/glide-mq, then `./scripts/sync-upstream.sh` pulls them here. Local hand-edits are out of policy and will be overwritten by the next sync.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Apache License 2.0, vendors and updates documentation for glide-mq skills (including migration guides from Bee-Queue and BullMQ), and introduces scripts for upstream synchronization and drift detection. The feedback focuses on improving the robustness of shell scripts by handling potential word splitting in file loops and simplifying data extraction pipelines. Additionally, it was noted that migration checklists in the documentation should be moved out of code blocks to ensure they render correctly as interactive elements.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a34e5b6. Configure here.
gemini and cursor flagged: - scripts/sync-upstream.sh used 'for f in $ref_files' which word-splits on spaces. Switched to 'while IFS= read -r f' so filenames with spaces are safe. Also -F to grep for literal-string matching. - scripts/check-upstream-drift.sh used brittle multi-stage grep against exact table cell formatting. Simplified to grep the SHA and version patterns directly anywhere in the file. - .github/workflows/check-upstream-drift.yml interpolated the upstream report directly into a heredoc inside a 'run:' block. Anything in the upstream commit messages or version strings could break out of the heredoc and execute arbitrary shell. Switched to passing the report via an env var and using printf with %s formatting so the report is treated as opaque data. All three are upstream-content edits that I am NOT re-syncing - they're in our owned scripts and workflows, not in the vendored SKILL.md files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace vendored `skills/glide-mq*` with the upstream content at `avifenesh/glide-mq@ae9c0fa6` (v0.15.1). Add LICENSE, an upstream tracker, a sync script, and a weekly CI drift check.
Why
Our SKILL.md files were stuck at thin-wrapper v1.0.0 while upstream had iterated to v0.15.1 with full API reference, AI-native primitives (token rate limiting, model fallback, vector search, suspend/resume, etc.), and proper migration guides. Users installing this plugin via the agentsys marketplace were getting 12-24 month old skill content.
Scope
Workflow going forward
Test plan
Note
Low Risk
Mostly documentation/content vendoring plus CI automation; main risk is workflow/scripts misbehaving (opening/duplicating issues or failing due to
gh/permissions), not product runtime behavior.Overview
Updates the vendored
skills/glide-mq*content to match upstreamavifenesh/glide-mq@v0.15.1(including substantial new/expanded migration guides and detailed reference docs underskills/**/references/).Adds vendoring governance and automation: a root
LICENSE(Apache-2.0),skills/UPSTREAM.mdpin/tracking metadata,scripts/sync-upstream.shto re-sync from any upstream ref,scripts/check-upstream-drift.shto detect drift vs upstreammain, and a scheduled GitHub Action (check-upstream-drift.yml) that opens/updates an issue when drift is detected.Reviewed by Cursor Bugbot for commit a34e5b6. Configure here.