Fix: KeyError 'message' in response.py when both keys missing#925
Closed
hurtdidit wants to merge 1 commit intoagent0ai:mainfrom
Closed
Fix: KeyError 'message' in response.py when both keys missing#925hurtdidit wants to merge 1 commit intoagent0ai:mainfrom
hurtdidit wants to merge 1 commit intoagent0ai:mainfrom
Conversation
Bug: response.py execute() crashes with KeyError when neither 'text' nor
'message' keys exist in self.args dictionary.
Current buggy code:
self.args['text'] if 'text' in self.args else self.args['message']
This fails when both keys are missing, causing agent to completely stall.
Fix: Use .get() method with safe fallback:
message_text = self.args.get('text') or self.args.get('message', '')
return Response(message=message_text, break_loop=True)
Impact: Prevents agent stalls in edge cases where response tool is
called without proper arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
response.pyexecute()crashes withKeyError: 'message'when neithertextnormessagekeys exist inself.argsdictionary.Current Buggy Code (line 7)
When both keys are missing, this throws
KeyError: 'message'and causes the agent to completely stall.Proposed Fix
Using
.get()with a safe fallback prevents the crash.Impact
Testing