refactor: consolidate JsonRpc trait implementations with macros#128
Merged
nikomatsakis merged 1 commit intoagentclientprotocol:mainfrom Mar 17, 2026
Merged
refactor: consolidate JsonRpc trait implementations with macros#128nikomatsakis merged 1 commit intoagentclientprotocol:mainfrom
nikomatsakis merged 1 commit intoagentclientprotocol:mainfrom
Conversation
Contributor
nikomatsakis
commented
Mar 17, 2026
nikomatsakis
commented
- Replace ~890 lines of repetitive trait implementations with concise macros
- Add impl_jsonrpc_request! and impl_jsonrpc_notification! macros in schema/mod.rs
- Add feature flags for unstable ACP methods (session_model, session_fork, etc.)
- All tests pass, no functional changes
- Replace ~890 lines of repetitive trait implementations with concise macros - Add impl_jsonrpc_request! and impl_jsonrpc_notification! macros in schema/mod.rs - Add feature flags for unstable ACP methods (session_model, session_fork, etc.) - All tests pass, no functional changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.