Skip to content

agentevals docker build and helm deploy#66

Merged
krisztianfekete merged 2 commits intoagentevals-dev:mainfrom
esara:docker
Mar 31, 2026
Merged

agentevals docker build and helm deploy#66
krisztianfekete merged 2 commits intoagentevals-dev:mainfrom
esara:docker

Conversation

@esara
Copy link
Copy Markdown
Contributor

@esara esara commented Mar 26, 2026

enable multiarch docker build with helm deploy

Comment thread Makefile
WHEEL := dist/agentevals_cli-$(VERSION)-py3-none-any.whl

.PHONY: build build-bundle build-ui release clean dev-backend dev-frontend dev-bundle test test-unit test-integration test-e2e
DOCKER_REGISTRY ?= soloio
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to set up the image builds too -- I think this will end up being ghcr.io (instead lof soloio). cc @EItanya as he's the master GH registry setter-upper.

Copy link
Copy Markdown
Contributor

@krisztianfekete krisztianfekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, added some comments!
Would you also have time to align it more closely to what kagent and agentregistry charts are doing to have consistency across these projects?

Comment thread charts/agentevals/values.yaml
Comment thread charts/agentevals/templates/deployment.yaml Outdated
Comment thread Dockerfile Outdated
description: agentevals web UI, OTLP HTTP receiver, and MCP (Streamable HTTP)
type: application
version: 0.1.0
appVersion: "0.5.2"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we auto-generete this from Makefile?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if modifying the chart from the makefile is a good idea, I think the helm chart should be modified with a new versions not from the build

Comment thread deploy/helm/agentevals/values.yaml Outdated
Comment thread charts/agentevals/values.yaml Outdated
Comment thread Makefile Outdated
Comment thread src/agentevals/cli.py Outdated
@krisztianfekete krisztianfekete mentioned this pull request Mar 27, 2026
1 task
Comment thread deploy/helm/agentevals/templates/ingress.yaml Outdated
@esara
Copy link
Copy Markdown
Contributor Author

esara commented Mar 31, 2026

thanks @krisztianfekete for the helm chart update!

@krisztianfekete krisztianfekete merged commit 3ce1707 into agentevals-dev:main Mar 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants