-
Notifications
You must be signed in to change notification settings - Fork 7
Break pcs out into separate dir and fix some broken example_agents #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…roject#329 but not sure there are other tests besides the 2 that I updated in this commit that need to clear the local repo cache as well.
…django webapp, add local repo cache clearing to webapp tests which further addresses agentos-project#329.
…the deletion fails becuase modules from those repos have been loaded into the current Python process.
example rl_agents.
|
@nickjalbert I think this and #326 are ready for review! |
nickjalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except it appears python scripts/build_docs.py is broken (it's still trying to import agentos/version.py instead of pcs/version.py). We'll also have to update the autodoc stubs in documentation/api to point to the new pcs location.
Not sure if that's what you meant by the docs not being updated, but we could port that in a different PR if you want to merge this one now.
for running these agents.
|
Ok @nickjalbert I think I've addressed all of your feedback and updated the main text of this PR to reflect the updates. If tests are green I think we are in good shape, though might be nice if you try out the newly updated |
|
Actually I just noticed this PR still doesn't add readme files to all of the example agents, which is one of the things you suggested. |
|
Build is green! Merging! Thanks for doing this. :) |
Fixes #289 and #337
This updates the API docs and also updates the
build_docs.pyscript to auto-generate the API docs with less manual work required to curate stub sphinx ReStructuredText files.This also fixes some syntax bugs in the example code in the REPL Quickstart in the documentation.